Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 13674006: cc: Use refresh_rate from LayerTreeSettings (Closed)

Created:
7 years, 8 months ago by jonathan.backer
Modified:
7 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Use refresh_rate from LayerTreeSettings We use it in compositor_unittests to have a faster refresh rate during test (when WGC3D is mocked out --- no hardware vsync). TEST=cc_unittests pass, compositor_unittests --ui-enable-threaded-compositing are faster Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192676

Patch Set 1 #

Patch Set 2 : Speed up all the tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M cc/test/layer_tree_test.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jonathan.backer
I'd like to use or nuke the setting. I think there's some value in keep ...
7 years, 8 months ago (2013-04-05 14:38:42 UTC) #1
danakj
LGTM Do you know how this plays out with plumbing the vsync info into the ...
7 years, 8 months ago (2013-04-05 14:44:00 UTC) #2
danakj
We could use this to speed up cc unit tests too. The LayerTreeTest class could ...
7 years, 8 months ago (2013-04-05 14:45:25 UTC) #3
jonathan.backer
On 2013/04/05 14:44:00, danakj wrote: > LGTM > > Do you know how this plays ...
7 years, 8 months ago (2013-04-05 14:58:24 UTC) #4
jonathan.backer
On 2013/04/05 14:45:25, danakj wrote: > We could use this to speed up cc unit ...
7 years, 8 months ago (2013-04-05 15:14:56 UTC) #5
danakj
Cool, thanks! LGTMstill
7 years, 8 months ago (2013-04-05 15:16:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/13674006/7003
7 years, 8 months ago (2013-04-05 18:58:13 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-06 00:47:06 UTC) #8
Message was sent while issue was closed.
Change committed as 192676

Powered by Google App Engine
This is Rietveld 408576698