Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13671005: Re-apply 192420: Move login switches to src/chromeos (Closed)

Created:
7 years, 8 months ago by stevenjb
Modified:
7 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, yusukes+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, kkania, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, sail+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, robertshield, dtseng+watch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Re-apply 192420: Move login switches to src/chromeos Includes fix for GOOGLE_CHROME_BUILD BUG=192420 TBR=ben@chromium.org, nkostylev@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -140 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 7 chunks +24 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_manager_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_in_process_browser_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/system/drm_settings.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/shell_integration.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest_chromeos.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/common/chrome_switches.cc View 3 chunks +0 lines, -33 lines 0 comments Download
M chrome/common/logging_chrome.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +12 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +39 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/13671005/1
7 years, 8 months ago (2013-04-05 01:02:40 UTC) #1
commit-bot: I haz the power
Change committed as 192504
7 years, 8 months ago (2013-04-05 04:34:34 UTC) #2
tkent
7 years, 8 months ago (2013-04-05 05:55:14 UTC) #3
Message was sent while issue was closed. 
On 2013/04/05 04:34:34, I haz the power (commit-bot) wrote:
> Change committed as 192504

This was rolled out because of a build failure on "Google Chrome ChromeOS" bot.

chrome/browser/ui/webui/options/browser_options_handler.cc: In member function
'void options::BrowserOptionsHandler::SetupMetricsReportingSettingVisibility()':
chrome/browser/ui/webui/options/browser_options_handler.cc:1423:error:
'chromeos::switches' has not been declared

Powered by Google App Engine
This is Rietveld 408576698