Issue 13668002: Assume extension_id can never be empty in user_script_slave.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13668002: Assume extension_id can never be empty in user_script_slave.cc (Closed)

Created:
7 years, 8 months ago by adamk

Modified:
7 years, 8 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Assume extension_id can never be empty in user_script_slave.cc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192618

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	chrome/renderer/extensions/user_script_slave.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

adamk

Background: I'm trying to improve the API of executeScriptInIsolatedWorld() to never pass 0 as the ...

7 years, 8 months ago (2013-04-05 00:49:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/13668002/1

7 years, 8 months ago (2013-04-05 01:08:46 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=131286

7 years, 8 months ago (2013-04-05 02:07:19 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/13668002/1

7 years, 8 months ago (2013-04-05 15:44:40 UTC) #5

Message was sent while issue was closed.

Change committed as 192618

Expand Messages | Collapse Messages