chrome/browser/ui/search/instant_controller.cc - Issue 13667002: InstantExtended: Disable setValue() for NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/instant_controller.cc

Issue 13667002: InstantExtended: Disable setValue() for NTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/instant_controller.cc

diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc

index 8dcc23badcd2c8ac4034bb6080f57d5ad555c2a2..da409c4961939765cbd0ed3228e43f3b490a5d47 100644

--- a/chrome/browser/ui/search/instant_controller.cc

+++ b/chrome/browser/ui/search/instant_controller.cc

@@ -1118,8 +1118,10 @@ void InstantController::SetSuggestions(

if (!suggestions.empty())

suggestion = suggestions[0];

+ // TODO(samarth): allow InstantTabs to call SetSuggestions() from the NTP once

+ // that is better supported.

bool can_use_instant_tab = UseInstantTabToShowSuggestions() &&

- !search_mode_.is_default();

+ search_mode_.is_search();

bool can_use_overlay = search_mode_.is_search_suggestions() &&

!last_omnibox_text_.empty();

if (!can_use_instant_tab && !can_use_overlay)

« no previous file with comments | « no previous file | no next file » | no next file with comments »