InstantExtended: Disable setValue() for NTP.

InstantExtended: Disable setValue() for NTP.

We don't currently handle setValue() calls on the NTP correctly. In particular,
we show misleading icons and emphasize wrong text. Disabling it until these
issues are fixed.

BUG=164784
TESTED=chrome.embeddedSearch.searchBox.setValue(...) is a no-op from the NTP.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192860

[samarth, 2013-04-04 22:11:50]

Please review.

Thanks,
Samarth

[samarth, 2013-04-04 23:17:07]

Changed to using is_search() rather than is_search_suggestions() as we discussed
offline.

It doesn't actually make a difference because of the can_use_overlay condition:
that's probably a mistake, but I want to think through that a bit more carefully
before changing it. (We can fix it when I restore the setValue() functionality
for the ntp.)

Thanks,
Samarth

[Jered, 2013-04-04 23:22:54]

lgtm

We should think of a better name for can_use_overlay.

On 2013/04/04 23:17:07, samarth wrote:
> Changed to using is_search() rather than is_search_suggestions() as we
discussed
> offline.
> 
> It doesn't actually make a difference because of the can_use_overlay
condition:
> that's probably a mistake, but I want to think through that a bit more
carefully
> before changing it. (We can fix it when I restore the setValue() functionality
> for the ntp.)
> 
> Thanks,
> Samarth

[commit-bot: I haz the power, 2013-04-05 20:37:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/13667002/8001

[Jered, 2013-04-05 20:39:21]

On 2013/04/05 20:37:37, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/samarth%40chromium.org/13667002/8001

Sorry I forgot to ask, could you add a test? Ok in a follow on CL.

[samarth, 2013-04-05 20:58:44]

Thanks for the reminder. I think this is actually a great time/place to start
adding some unit tests (this change really doesn't deserve a browser test).

I'm going to start looking at it and send you a separate Cl for it.

Thanks,
Samarth

[commit-bot: I haz the power, 2013-04-05 20:59:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/13667002/17001

[commit-bot: I haz the power, 2013-04-05 23:38:15]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-08 02:46:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/13667002/17001

[sreeram, 2013-04-08 03:48:22]

On Thu, Apr 4, 2013 at 3:11 PM,  <samarth@chromium.org> wrote:
> BUG=none

You should've included the original bug (164784) which will now be unfixed.

[commit-bot: I haz the power, 2013-04-08 04:22:08]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-08 18:34:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/13667002/17001

[commit-bot: I haz the power, 2013-04-08 19:30:08]

Change committed as 192860