[Sync] Fix favicon updates to handle orphan nodes

[Sync] Fix favicon updates to handle orphan nodes

Image and tracking updates are now tracked separately, so that we properly
distinguish between adds/updates.

BUG=226539
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192503

[Nicolas Zea, 2013-04-04 22:47:50]

PTAL

[rlarocque, 2013-04-04 23:29:07]

LGTM with some comments.

https://codereview.chromium.org/13666003/diff/5001/chrome/browser/sync/glue/f...
File chrome/browser/sync/glue/favicon_cache.cc (right):

https://codereview.chromium.org/13666003/diff/5001/chrome/browser/sync/glue/f...
chrome/browser/sync/glue/favicon_cache.cc:656: UpdateSyncState(favicon_url,
I dislike ternary operators, and wouldn't use them myself, but I'm willing to
let it slide in code reviews.  I draw the line at nested ternary operators. 
Please rewrite this logic as an if statement.

https://codereview.chromium.org/13666003/diff/5001/chrome/browser/sync/glue/f...
File chrome/browser/sync/glue/favicon_cache.h (right):

https://codereview.chromium.org/13666003/diff/5001/chrome/browser/sync/glue/f...
chrome/browser/sync/glue/favicon_cache.h:150: // either |image_change_type| or
|tracking_change_type| is ACITON_INVALID,
typo: ACTION_INVALID.

[Nicolas Zea, 2013-04-04 23:42:29]

Done. PTAL again, since I also updated the nudge policy for favicons to be the
same as Sessions, since with this change we'll now be triggering tracking
updates at a higher rate.

https://codereview.chromium.org/13666003/diff/5001/chrome/browser/sync/glue/f...
File chrome/browser/sync/glue/favicon_cache.cc (right):

https://codereview.chromium.org/13666003/diff/5001/chrome/browser/sync/glue/f...
chrome/browser/sync/glue/favicon_cache.cc:656: UpdateSyncState(favicon_url,
On 2013/04/04 23:29:07, rlarocque wrote:
> I dislike ternary operators, and wouldn't use them myself, but I'm willing to
> let it slide in code reviews.  I draw the line at nested ternary operators. 
> Please rewrite this logic as an if statement.  

Haha, ok, done.

https://codereview.chromium.org/13666003/diff/5001/chrome/browser/sync/glue/f...
File chrome/browser/sync/glue/favicon_cache.h (right):

https://codereview.chromium.org/13666003/diff/5001/chrome/browser/sync/glue/f...
chrome/browser/sync/glue/favicon_cache.h:150: // either |image_change_type| or
|tracking_change_type| is ACITON_INVALID,
On 2013/04/04 23:29:07, rlarocque wrote:
> typo: ACTION_INVALID.

Done.

[rlarocque, 2013-04-04 23:46:48]

LGTM

[commit-bot: I haz the power, 2013-04-04 23:47:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/13666003/13001

[commit-bot: I haz the power, 2013-04-05 04:34:08]

Change committed as 192503