build/toolchain/nacl/BUILD.gn - Issue 1365973004: Build PPAPI PNaCl Newlib tests with GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/nacl/BUILD.gn

Issue 1365973004: Build PPAPI PNaCl Newlib tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-is-pnacl

Patch Set: Review feedback addressed Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/nacl/BUILD.gn

diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn

index 686960297d403f7725801860811a5c6aee67d5ce..5addfb95c19c455e2940ffe4dc651fcd5e9d6b4e 100644

--- a/build/toolchain/nacl/BUILD.gn

+++ b/build/toolchain/nacl/BUILD.gn

@@ -3,11 +3,9 @@

# found in the LICENSE file.

import("//build/config/sysroot.gni")

+import("//build/config/nacl/config.gni")

import("//build/toolchain/nacl_toolchain.gni")

-nacl_toolchain_dir = rebase_path("//native_client/toolchain", root_build_dir)

-os_toolchain_dir = "${nacl_toolchain_dir}/${host_os}_x86"

# Add the toolchain revision as a preprocessor define so that sources are

# rebuilt when a toolchain is updated.

# Idea we could use the toolchain deps feature, but currently that feature is