build/config/nacl/config.gni - Issue 1365973004: Build PPAPI PNaCl Newlib tests with GN

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/nacl/config.gni

Issue 1365973004: Build PPAPI PNaCl Newlib tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-is-pnacl

Patch Set: Review feedback addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 nacl_toolchain_dir = rebase_path("//native_client/toolchain", root_build_dir)

	6 os_toolchain_dir = "${nacl_toolchain_dir}/${host_os}_x86"
	brettw 2015/10/01 17:27:36 Since this is going to be basically a global varia Since this is going to be basically a global variable now, I think it would be best to have "nacl" in the name somewhere. I'm not sure enough if what this is to be able to suggest a good name, though. Can these also have comments, for the same reason? I normally put declare_args at the top, and other stuff below it. Petr Hosek 2015/10/03 05:25:27 Done. Show quoted text On 2015/10/01 17:27:36, brettw wrote: > Since this is going to be basically a global variable now, I think it would be > best to have "nacl" in the name somewhere. I'm not sure enough if what this is > to be able to suggest a good name, though. Can these also have comments, for the > same reason? > > I normally put declare_args at the top, and other stuff below it. Done.
	7

5 declare_args() {	8 declare_args() {

6 # Native Client supports both Newlib and Glibc C libraries where Newlib	9 # Native Client supports both Newlib and Glibc C libraries where Newlib

7 # is assumed to be the default one; use this to determine whether Glibc	10 # is assumed to be the default one; use this to determine whether Glibc

8 # is being used instead.	11 # is being used instead.

9 is_nacl_glibc = false	12 is_nacl_glibc = false

10 }	13 }

OLD	NEW

« no previous file with comments | « no previous file | build/toolchain/nacl/BUILD.gn » ('j') | no next file with comments »