Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typos Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 virtual void setScrollPosition(const DoublePoint&, ScrollType, ScrollBehavio r = ScrollBehaviorInstant); 88 virtual void setScrollPosition(const DoublePoint&, ScrollType, ScrollBehavio r = ScrollBehaviorInstant);
89 virtual void scrollBy(const DoubleSize&, ScrollType, ScrollBehavior = Scroll BehaviorInstant); 89 virtual void scrollBy(const DoubleSize&, ScrollType, ScrollBehavior = Scroll BehaviorInstant);
90 void setScrollPositionSingleAxis(ScrollbarOrientation, double, ScrollType, S crollBehavior = ScrollBehaviorInstant); 90 void setScrollPositionSingleAxis(ScrollbarOrientation, double, ScrollType, S crollBehavior = ScrollBehaviorInstant);
91 91
92 // Scrolls the area so that the given rect, given in the document's content coordinates, such that it's 92 // Scrolls the area so that the given rect, given in the document's content coordinates, such that it's
93 // visible in the area. Returns the new location of the input rect relative once again to the document. 93 // visible in the area. Returns the new location of the input rect relative once again to the document.
94 // Note, in the case of a Document container, such as FrameView, the output will always be the input rect 94 // Note, in the case of a Document container, such as FrameView, the output will always be the input rect
95 // since scrolling it can't change the location of content relative to the d ocument, unlike an overflowing 95 // since scrolling it can't change the location of content relative to the d ocument, unlike an overflowing
96 // element. 96 // element.
97 virtual LayoutRect scrollIntoView(const LayoutRect& rectInContent, const Scr ollAlignment& alignX, const ScrollAlignment& alignY); 97 virtual LayoutRect scrollIntoView(const LayoutRect& rectInContent, const Scr ollAlignment& alignX, const ScrollAlignment& alignY, ScrollType = ProgrammaticSc roll);
98 98
99 // Scrolls the area so that the given rect, given in the area's content coor dinates, such that it's 99 // Scrolls the area so that the given rect, given in the area's content coor dinates, such that it's
100 // cenetered in the second rect, which is given relative to the area's origi n. 100 // cenetered in the second rect, which is given relative to the area's origi n.
101 void scrollIntoRect(const LayoutRect& rectInContent, const FloatRect& target RectInFrame); 101 void scrollIntoRect(const LayoutRect& rectInContent, const FloatRect& target RectInFrame);
102 102
103 static bool scrollBehaviorFromString(const String&, ScrollBehavior&); 103 static bool scrollBehaviorFromString(const String&, ScrollBehavior&);
104 104
105 bool inLiveResize() const { return m_inLiveResize; } 105 bool inLiveResize() const { return m_inLiveResize; }
106 void willStartLiveResize(); 106 void willStartLiveResize();
107 void willEndLiveResize(); 107 void willEndLiveResize();
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 // vertical-lr / ltr NO NO 365 // vertical-lr / ltr NO NO
366 // vertical-lr / rtl NO YES 366 // vertical-lr / rtl NO YES
367 // vertical-rl / ltr YES NO 367 // vertical-rl / ltr YES NO
368 // vertical-rl / rtl YES YES 368 // vertical-rl / rtl YES YES
369 IntPoint m_scrollOrigin; 369 IntPoint m_scrollOrigin;
370 }; 370 };
371 371
372 } // namespace blink 372 } // namespace blink
373 373
374 #endif // ScrollableArea_h 374 #endif // ScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698