Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typos Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 // The following six functions are used when the layout tree hierarchy chang es to make sure layers get 210 // The following six functions are used when the layout tree hierarchy chang es to make sure layers get
211 // properly added and removed. Since containership can be implemented by an y subclass, and since a hierarchy 211 // properly added and removed. Since containership can be implemented by an y subclass, and since a hierarchy
212 // can contain a mixture of boxes and other object types, these functions ne ed to be in the base class. 212 // can contain a mixture of boxes and other object types, these functions ne ed to be in the base class.
213 DeprecatedPaintLayer* enclosingLayer() const; 213 DeprecatedPaintLayer* enclosingLayer() const;
214 void addLayers(DeprecatedPaintLayer* parentLayer); 214 void addLayers(DeprecatedPaintLayer* parentLayer);
215 void removeLayers(DeprecatedPaintLayer* parentLayer); 215 void removeLayers(DeprecatedPaintLayer* parentLayer);
216 void moveLayers(DeprecatedPaintLayer* oldParent, DeprecatedPaintLayer* newPa rent); 216 void moveLayers(DeprecatedPaintLayer* oldParent, DeprecatedPaintLayer* newPa rent);
217 DeprecatedPaintLayer* findNextLayer(DeprecatedPaintLayer* parentLayer, Layou tObject* startPoint, bool checkParent = true); 217 DeprecatedPaintLayer* findNextLayer(DeprecatedPaintLayer* parentLayer, Layou tObject* startPoint, bool checkParent = true);
218 218
219 // Scrolling is a LayoutBox concept, however some code just cares about recu rsively scrolling our enclosing ScrollableArea(s). 219 // Scrolling is a LayoutBox concept, however some code just cares about recu rsively scrolling our enclosing ScrollableArea(s).
220 bool scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX = ScrollAlignment::alignCenterIfNeeded, const ScrollAlignment& alignY = ScrollAlig nment::alignCenterIfNeeded); 220 bool scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX = ScrollAlignment::alignCenterIfNeeded, const ScrollAlignment& alignY = ScrollAlig nment::alignCenterIfNeeded, ScrollType = ProgrammaticScroll);
221 221
222 // Convenience function for getting to the nearest enclosing box of a Layout Object. 222 // Convenience function for getting to the nearest enclosing box of a Layout Object.
223 LayoutBox* enclosingBox() const; 223 LayoutBox* enclosingBox() const;
224 LayoutBoxModelObject* enclosingBoxModelObject() const; 224 LayoutBoxModelObject* enclosingBoxModelObject() const;
225 225
226 LayoutBox* enclosingScrollableBox() const; 226 LayoutBox* enclosingScrollableBox() const;
227 227
228 // Function to return our enclosing flow thread if we are contained inside o ne. This 228 // Function to return our enclosing flow thread if we are contained inside o ne. This
229 // function follows the containing block chain. 229 // function follows the containing block chain.
230 LayoutFlowThread* flowThreadContainingBlock() const 230 LayoutFlowThread* flowThreadContainingBlock() const
(...skipping 1671 matching lines...) Expand 10 before | Expand all | Expand 10 after
1902 void showTree(const blink::LayoutObject*); 1902 void showTree(const blink::LayoutObject*);
1903 void showLineTree(const blink::LayoutObject*); 1903 void showLineTree(const blink::LayoutObject*);
1904 void showLayoutTree(const blink::LayoutObject* object1); 1904 void showLayoutTree(const blink::LayoutObject* object1);
1905 // We don't make object2 an optional parameter so that showLayoutTree 1905 // We don't make object2 an optional parameter so that showLayoutTree
1906 // can be called from gdb easily. 1906 // can be called from gdb easily.
1907 void showLayoutTree(const blink::LayoutObject* object1, const blink::LayoutObjec t* object2); 1907 void showLayoutTree(const blink::LayoutObject* object1, const blink::LayoutObjec t* object2);
1908 1908
1909 #endif 1909 #endif
1910 1910
1911 #endif // LayoutObject_h 1911 #endif // LayoutObject_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698