Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: third_party/WebKit/Source/core/frame/RootFrameViewport.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typos Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef RootFrameViewport_h 5 #ifndef RootFrameViewport_h
6 #define RootFrameViewport_h 6 #define RootFrameViewport_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "platform/scroll/ScrollableArea.h" 9 #include "platform/scroll/ScrollableArea.h"
10 10
(...skipping 19 matching lines...) Expand all
30 return adoptPtrWillBeNoop(new RootFrameViewport(visualViewport, layoutVi ewport, invertScrollOrder)); 30 return adoptPtrWillBeNoop(new RootFrameViewport(visualViewport, layoutVi ewport, invertScrollOrder));
31 } 31 }
32 32
33 DECLARE_VIRTUAL_TRACE(); 33 DECLARE_VIRTUAL_TRACE();
34 34
35 // ScrollableArea Implementation 35 // ScrollableArea Implementation
36 void setScrollPosition(const DoublePoint&, ScrollType, ScrollBehavior = Scro llBehaviorInstant) override; 36 void setScrollPosition(const DoublePoint&, ScrollType, ScrollBehavior = Scro llBehaviorInstant) override;
37 LayoutRect scrollIntoView( 37 LayoutRect scrollIntoView(
38 const LayoutRect& rectInContent, 38 const LayoutRect& rectInContent,
39 const ScrollAlignment& alignX, 39 const ScrollAlignment& alignX,
40 const ScrollAlignment& alignY) override; 40 const ScrollAlignment& alignY,
41 ScrollType = ProgrammaticScroll) override;
skobes 2015/09/30 22:31:14 nit: extra space
ymalik 2015/10/01 22:25:31 Done.
41 DoubleRect visibleContentRectDouble(IncludeScrollbarsInRect = ExcludeScrollb ars) const override; 42 DoubleRect visibleContentRectDouble(IncludeScrollbarsInRect = ExcludeScrollb ars) const override;
42 IntRect visibleContentRect(IncludeScrollbarsInRect = ExcludeScrollbars) cons t override; 43 IntRect visibleContentRect(IncludeScrollbarsInRect = ExcludeScrollbars) cons t override;
43 bool shouldUseIntegerScrollOffset() const override; 44 bool shouldUseIntegerScrollOffset() const override;
44 bool isActive() const override; 45 bool isActive() const override;
45 int scrollSize(ScrollbarOrientation) const override; 46 int scrollSize(ScrollbarOrientation) const override;
46 bool isScrollCornerVisible() const override; 47 bool isScrollCornerVisible() const override;
47 IntRect scrollCornerRect() const override; 48 IntRect scrollCornerRect() const override;
48 void setScrollOffset(const IntPoint&, ScrollType) override; 49 void setScrollOffset(const IntPoint&, ScrollType) override;
49 void setScrollOffset(const DoublePoint&, ScrollType) override; 50 void setScrollOffset(const DoublePoint&, ScrollType) override;
50 IntPoint scrollPosition() const override; 51 IntPoint scrollPosition() const override;
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 RawPtrWillBeMember<ScrollableArea> m_layoutViewport; 90 RawPtrWillBeMember<ScrollableArea> m_layoutViewport;
90 91
91 // Experimental flag. If the experiment is enabled, scroll the visual viewpo rt first, 92 // Experimental flag. If the experiment is enabled, scroll the visual viewpo rt first,
92 // the bubble scrolls to the layout viewport. 93 // the bubble scrolls to the layout viewport.
93 bool m_invertScrollOrder; 94 bool m_invertScrollOrder;
94 }; 95 };
95 96
96 } // namespace blink 97 } // namespace blink
97 98
98 #endif // RootFrameViewport_h 99 #endif // RootFrameViewport_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698