Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1365853003: LayoutBox::scrollRectToVisible doesn't respect overflow:hidden property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typos Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 GraphicsLayer* layerForHorizontalScrollbar() const override; 355 GraphicsLayer* layerForHorizontalScrollbar() const override;
356 GraphicsLayer* layerForVerticalScrollbar() const override; 356 GraphicsLayer* layerForVerticalScrollbar() const override;
357 GraphicsLayer* layerForScrollCorner() const override; 357 GraphicsLayer* layerForScrollCorner() const override;
358 int scrollSize(ScrollbarOrientation) const override; 358 int scrollSize(ScrollbarOrientation) const override;
359 bool isScrollCornerVisible() const override; 359 bool isScrollCornerVisible() const override;
360 bool userInputScrollable(ScrollbarOrientation) const override; 360 bool userInputScrollable(ScrollbarOrientation) const override;
361 bool shouldPlaceVerticalScrollbarOnLeft() const override; 361 bool shouldPlaceVerticalScrollbarOnLeft() const override;
362 virtual LayoutRect scrollIntoView( 362 virtual LayoutRect scrollIntoView(
363 const LayoutRect& rectInContent, 363 const LayoutRect& rectInContent,
364 const ScrollAlignment& alignX, 364 const ScrollAlignment& alignX,
365 const ScrollAlignment& alignY) override; 365 const ScrollAlignment& alignY,
366 ScrollType = ProgrammaticScroll) override;
366 367
367 // The window that hosts the FrameView. The FrameView will communicate scrol ls and repaints to the 368 // The window that hosts the FrameView. The FrameView will communicate scrol ls and repaints to the
368 // host window in the window's coordinate space. 369 // host window in the window's coordinate space.
369 HostWindow* hostWindow() const override; 370 HostWindow* hostWindow() const override;
370 371
371 // Returns a clip rect in host window coordinates. Used to clip the blit on a scroll. 372 // Returns a clip rect in host window coordinates. Used to clip the blit on a scroll.
372 IntRect windowClipRect(IncludeScrollbarsInRect = ExcludeScrollbars) const; 373 IntRect windowClipRect(IncludeScrollbarsInRect = ExcludeScrollbars) const;
373 374
374 typedef WillBeHeapHashSet<RefPtrWillBeMember<Widget>> ChildrenWidgetSet; 375 typedef WillBeHeapHashSet<RefPtrWillBeMember<Widget>> ChildrenWidgetSet;
375 376
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 static const unsigned visualPixelThreshold = 32 * 32; 858 static const unsigned visualPixelThreshold = 32 * 32;
858 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 859 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
859 setIsVisuallyNonEmpty(); 860 setIsVisuallyNonEmpty();
860 } 861 }
861 862
862 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 863 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
863 864
864 } // namespace blink 865 } // namespace blink
865 866
866 #endif // FrameView_h 867 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698