Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: net/url_request/url_request_job.h

Issue 13653003: Fix a load timing bug in the case of SPDY session reuse (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove bonus whitespace, add test Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 virtual UploadProgress GetUploadProgress() const; 110 virtual UploadProgress GetUploadProgress() const;
111 111
112 // Called to fetch the charset for this request. Only makes sense for some 112 // Called to fetch the charset for this request. Only makes sense for some
113 // types of requests. Returns true on success. Calling this on a type that 113 // types of requests. Returns true on success. Calling this on a type that
114 // doesn't have a charset will return false. 114 // doesn't have a charset will return false.
115 virtual bool GetCharset(std::string* charset); 115 virtual bool GetCharset(std::string* charset);
116 116
117 // Called to get response info. 117 // Called to get response info.
118 virtual void GetResponseInfo(HttpResponseInfo* info); 118 virtual void GetResponseInfo(HttpResponseInfo* info);
119 119
120 // This returns the times when events actually occurred, rather than the time
121 // each event blocked the request. See FixupLoadTimingInfo in url_request.h
122 // for more information on the difference.
120 virtual void GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const; 123 virtual void GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const;
121 124
122 // Returns the cookie values included in the response, if applicable. 125 // Returns the cookie values included in the response, if applicable.
123 // Returns true if applicable. 126 // Returns true if applicable.
124 // NOTE: This removes the cookies from the job, so it will only return 127 // NOTE: This removes the cookies from the job, so it will only return
125 // useful results once per job. 128 // useful results once per job.
126 virtual bool GetResponseCookies(std::vector<std::string>* cookies); 129 virtual bool GetResponseCookies(std::vector<std::string>* cookies);
127 130
128 // Called to setup a stream filter for this request. An example of filter is 131 // Called to setup a stream filter for this request. An example of filter is
129 // content encoding/decoding. 132 // content encoding/decoding.
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 NetworkDelegate* network_delegate_; 395 NetworkDelegate* network_delegate_;
393 396
394 base::WeakPtrFactory<URLRequestJob> weak_factory_; 397 base::WeakPtrFactory<URLRequestJob> weak_factory_;
395 398
396 DISALLOW_COPY_AND_ASSIGN(URLRequestJob); 399 DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
397 }; 400 };
398 401
399 } // namespace net 402 } // namespace net
400 403
401 #endif // NET_URL_REQUEST_URL_REQUEST_JOB_H_ 404 #endif // NET_URL_REQUEST_URL_REQUEST_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698