Refactor ChunkDemuxer code so all source state is in a SourceState class.

Refactor ChunkDemuxer code so all source state is in a SourceState class.


BUG=172688
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192673

[scherkus (not reviewing), 2013-04-05 18:58:26]

lgtm w/ nits

https://codereview.chromium.org/13652012/diff/4001/media/filters/chunk_demuxe...
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/13652012/diff/4001/media/filters/chunk_demuxe...
media/filters/chunk_demuxer.cc:25: class SourceState {
does it make any sense to split this class out + unit-test-ify it?

https://codereview.chromium.org/13652012/diff/4001/media/filters/chunk_demuxer.h
File media/filters/chunk_demuxer.h (right):

https://codereview.chromium.org/13652012/diff/4001/media/filters/chunk_demuxe...
media/filters/chunk_demuxer.h:23: class SourceState;
A->Z

[acolwell GONE FROM CHROMIUM, 2013-04-05 19:14:37]

https://codereview.chromium.org/13652012/diff/4001/media/filters/chunk_demuxe...
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/13652012/diff/4001/media/filters/chunk_demuxe...
media/filters/chunk_demuxer.cc:25: class SourceState {
On 2013/04/05 18:58:26, scherkus wrote:
> does it make any sense to split this class out + unit-test-ify it?
I'm not sure it quite makes sense yet. I think ChunkDemuxer and SourceState are
still a little too coupled right now for us to have separate unit tests for
each. I expect further refactoring will make these 2 classes a little more
independent and I think I'll be able to refactor the tests then.

https://codereview.chromium.org/13652012/diff/4001/media/filters/chunk_demuxer.h
File media/filters/chunk_demuxer.h (right):

https://codereview.chromium.org/13652012/diff/4001/media/filters/chunk_demuxe...
media/filters/chunk_demuxer.h:23: class SourceState;
On 2013/04/05 18:58:26, scherkus wrote:
> A->Z

Done.

[commit-bot: I haz the power, 2013-04-05 19:15:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/13652012/16001

[commit-bot: I haz the power, 2013-04-06 00:43:23]

Change committed as 192673