Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: build/download_nacl_toolchains.py

Issue 13652003: Update NaCl ARM build flags now that gcc used as default compiler. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: remove dup Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « DEPS ('k') | ppapi/native_client/native_client.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Shim to run nacl toolchain download script only if there is a nacl dir.""" 6 """Shim to run nacl toolchain download script only if there is a nacl dir."""
7 7
8 import os 8 import os
9 import sys 9 import sys
10 10
(...skipping 11 matching lines...) Expand all
22 print "Can't find '%s'" % download_script 22 print "Can't find '%s'" % download_script
23 print 'Presumably you are intentionally building without NativeClient.' 23 print 'Presumably you are intentionally building without NativeClient.'
24 print 'Skipping NativeClient toolchain download.' 24 print 'Skipping NativeClient toolchain download.'
25 sys.exit(0) 25 sys.exit(0)
26 sys.path.insert(0, nacl_build_dir) 26 sys.path.insert(0, nacl_build_dir)
27 import download_toolchains 27 import download_toolchains
28 28
29 # TODO (robertm): Finish getting PNaCl ready for prime time. 29 # TODO (robertm): Finish getting PNaCl ready for prime time.
30 # BUG: 30 # BUG:
31 # We remove this --optional-pnacl argument, and instead replace it with 31 # We remove this --optional-pnacl argument, and instead replace it with
32 # --no-pnacl for most cases. However, if the bot name is the pnacl_sdk 32 # --no-pnacl for most cases. However, if the bot name is an sdk
33 # bot then we will go ahead and download it. This prevents increasing the 33 # bot then we will go ahead and download it. This prevents increasing the
34 # gclient sync time for developers, or standard Chrome bots. 34 # gclient sync time for developers, or standard Chrome bots.
35 if '--optional-pnacl' in args: 35 if '--optional-pnacl' in args:
36 args.remove('--optional-pnacl') 36 args.remove('--optional-pnacl')
37 # By default we don't use PNaCl toolchain yet, unless on ARM, where
38 # there is no other toolchain to build untrusted code at the moment.
39 # So analyze if we're building for ARM, or on SDK buildbot.
40 # TODO(olonho): we need to invent more reliable way to get build
41 # configuration info, to know if we're building for ARM.
42 use_pnacl = False 37 use_pnacl = False
43 if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''):
44 use_pnacl = True
45 buildbot_name = os.environ.get('BUILDBOT_BUILDERNAME', '') 38 buildbot_name = os.environ.get('BUILDBOT_BUILDERNAME', '')
46 if buildbot_name.find('pnacl') >= 0 and buildbot_name.find('sdk') >= 0: 39 if 'pnacl' in buildbot_name and 'sdk' in buildbot_name:
47 use_pnacl = True 40 use_pnacl = True
48 if use_pnacl: 41 if use_pnacl:
49 print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n' 42 print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n'
50 else: 43 else:
51 args.append('--no-pnacl') 44 args.append('--no-pnacl')
52 45
46 # Only download the ARM gcc toolchain if we are building for ARM
47 # TODO(olonho): we need to invent more reliable way to get build
48 # configuration info, to know if we're building for ARM.
49 if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''):
50 args.append('--arm-untrusted')
51
53 # Append the name of the file to use as a version and hash source. 52 # Append the name of the file to use as a version and hash source.
54 # NOTE: While not recommended, it is possible to redirect this file to 53 # NOTE: While not recommended, it is possible to redirect this file to
55 # a chrome location to avoid branching NaCl if just a toolchain needs 54 # a chrome location to avoid branching NaCl if just a toolchain needs
56 # to be bumped. 55 # to be bumped.
57 args.append(os.path.join(nacl_dir,'TOOL_REVISIONS')) 56 args.append(os.path.join(nacl_dir, 'TOOL_REVISIONS'))
58 57
59 download_toolchains.main(args) 58 download_toolchains.main(args)
60 return 0 59 return 0
61 60
62 61
63 if __name__ == '__main__': 62 if __name__ == '__main__':
64 sys.exit(Main(sys.argv[1:])) 63 sys.exit(Main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « DEPS ('k') | ppapi/native_client/native_client.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698