Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 13651003: Package correct libraries in apk (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
shashi, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Package correct libraries in apk With gyp_managed_install no shared libraries should be packaged in the APK (except gdbserver). When toggling gyp_managed_install, there may be left over libraries in <(intermediate_dir)/libs. APK packaging should use a different directory when doing a managed install, so that it does not include the library from a non-gyp_managed_install build. BUG=158821

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/android/ant/apk-package.xml View 1 chunk +1 line, -1 line 0 comments Download
M build/java_apk.gypi View 1 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-04 18:13:29 UTC) #1
shashi
lgtm
7 years, 8 months ago (2013-04-04 18:53:44 UTC) #2
cjhopman
7 years, 8 months ago (2013-04-04 19:57:03 UTC) #3
cjhopman
yfriedman@ for OWNERS
7 years, 8 months ago (2013-04-04 19:57:13 UTC) #4
Yaron
lgtm https://codereview.chromium.org/13651003/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/13651003/diff/1/build/java_apk.gypi#newcode270 build/java_apk.gypi:270: }, { Nit: Add # gyp_managed_install != 1
7 years, 8 months ago (2013-04-04 20:31:47 UTC) #5
cjhopman
https://codereview.chromium.org/13651003/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/13651003/diff/1/build/java_apk.gypi#newcode270 build/java_apk.gypi:270: }, { On 2013/04/04 20:31:47, Yaron wrote: > Nit: ...
7 years, 8 months ago (2013-04-05 16:46:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13651003/9001
7 years, 8 months ago (2013-04-05 16:46:34 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 19:55:23 UTC) #8
Couldn't make sense out of svn commit message:
Sending        build/android/ant/apk-package.xml
Sending        build/java_apk.gypi
Transmitting file data ..
Committed revision 192617.

Warning: post-commit hook failed (exit code 2) with output:
/opt/shared_hooks/post-commit.d/10_mailer.py:137: DeprecationWarning: The popen2
module is deprecated.  Use the subprocess module.
  import popen2
Post-commit mail timed out for r192617. Your commit succeeded,
but no mail was sent.

Powered by Google App Engine
This is Rietveld 408576698