Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 13650007: Move WebData component unittests to //components/webdata. (Closed)

Created:
7 years, 8 months ago by Cait (Slow)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Raman Kakilate, akalin, Raghu Simha, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, haitaol1, Ilya Sherman, tim (not reviewing)
Visibility:
Public.

Description

Move WebData component unittests to //components/webdata. TBR=ben@chromium.org BUG=181277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4058 lines) Patch
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/webdata/autofill_entry_unittest.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/webdata/autofill_table_unittest.cc View 1 chunk +0 lines, -1328 lines 0 comments Download
D chrome/browser/webdata/web_data_service_test_util.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/webdata/web_data_service_test_util.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/webdata/web_data_service_unittest.cc View 1 chunk +0 lines, -532 lines 0 comments Download
D chrome/browser/webdata/web_database_migration_unittest.cc View 1 chunk +0 lines, -1991 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +9 lines, -6 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/webdata/DEPS View 1 chunk +18 lines, -4 lines 0 comments Download
A + components/webdata/autofill/autofill_entry_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/webdata/autofill/autofill_table_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/webdata/autofill/web_data_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A + components/webdata/autofill/web_database_migration_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/webdata/common/web_data_service_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webdata/common/web_data_service_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Cait (Slow)
Joi: PTAL at DEPS changes -- also, should I move the unittests for the un-componentized ...
7 years, 8 months ago (2013-04-04 19:34:59 UTC) #1
dhollowa
lgtm
7 years, 8 months ago (2013-04-04 20:19:08 UTC) #2
Jói
LGTM with a nit on the change description: "Move WebData component unittests to //components/webdata." Correct, ...
7 years, 8 months ago (2013-04-04 21:24:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/13650007/1
7 years, 8 months ago (2013-04-05 14:40:44 UTC) #4
commit-bot: I haz the power
Presubmit check for 13650007-1 failed and returned exit status 1. INFO:root:Found 11 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-05 14:40:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/13650007/1
7 years, 8 months ago (2013-04-05 14:44:59 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 18:41:26 UTC) #7
Message was sent while issue was closed.
Change committed as 192608

Powered by Google App Engine
This is Rietveld 408576698