Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 13649010: Add provision_devices step to all Android testers. (Closed)

Created:
7 years, 8 months ago by Siva Chandra
Modified:
7 years, 8 months ago
Reviewers:
Isaac (away), ppi
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Add provision_devices step to all Android testers. This CL adds --auto-reconnect as an option to the provisioning script. This option is not being used. BUG=164180 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192668

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address ilevy's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/provision_devices.py View 1 3 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Siva Chandra
7 years, 8 months ago (2013-04-04 21:06:24 UTC) #1
Isaac (away)
this looks good. I have a couple nits but generally looks solid. https://chromiumcodereview.appspot.com/13649010/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py ...
7 years, 8 months ago (2013-04-05 05:41:18 UTC) #2
Isaac (away)
https://chromiumcodereview.appspot.com/13649010/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://chromiumcodereview.appspot.com/13649010/diff/1/build/android/buildbot/bb_device_steps.py#newcode276 build/android/buildbot/bb_device_steps.py:276: RunCmd(['build/android/provision_devices.py']) On 2013/04/05 05:41:18, Isaac wrote: > Let's pass ...
7 years, 8 months ago (2013-04-05 05:41:47 UTC) #3
Siva Chandra
PTAL https://chromiumcodereview.appspot.com/13649010/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://chromiumcodereview.appspot.com/13649010/diff/1/build/android/buildbot/bb_device_steps.py#newcode276 build/android/buildbot/bb_device_steps.py:276: RunCmd(['build/android/provision_devices.py']) On 2013/04/05 05:41:47, Isaac wrote: > On ...
7 years, 8 months ago (2013-04-05 20:55:31 UTC) #4
Isaac (away)
LGTM, thanks for making the changes.
7 years, 8 months ago (2013-04-05 21:17:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/13649010/8001
7 years, 8 months ago (2013-04-05 21:40:30 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-06 00:25:21 UTC) #7
Message was sent while issue was closed.
Change committed as 192668

Powered by Google App Engine
This is Rietveld 408576698