Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 13649002: Fix missing scrollbar thumb on WinXP. (Closed)

Created:
7 years, 8 months ago by Vangelis Kokkevis
Modified:
7 years, 8 months ago
Reviewers:
vangelis, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Fix missing scrollbar thumb on WinXP. It turns out that the XP theme, the default desktop theme on WindowsXP, draws the scrollbar thumb and its grippers with an alpha value of zero and therefore they become invisible. This patch sends them down the "indirect draw" path that paints them to an off-screen canvas and fixes their alpha values. I considered sending all scrollbar draws through the indirect path since there could in theory be other themes that suffer from the same issue but decided against it given the inefficiency of the indirect drawing path. At this point the only theme that seems to have this issue is the XP theme which is only available on WinXP. Note that the Windows Classic theme which is available on later versions of the OS is different from the XP theme and is already going down the indirect draw path. The Windows Classic theme is the only theme for which GetThemeHandle(SCROLLBAR) returns NULL. BUG=179643 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/native_theme/native_theme_win.cc View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vangelis
Scott, mind taking a look at this one?
7 years, 8 months ago (2013-04-04 16:39:06 UTC) #1
sky
LGTM
7 years, 8 months ago (2013-04-04 17:38:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/13649002/1
7 years, 8 months ago (2013-04-04 18:07:48 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 18:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vangelis@chromium.org/13649002/1
7 years, 8 months ago (2013-04-04 21:29:11 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 00:07:30 UTC) #6
Message was sent while issue was closed.
Change committed as 192428

Powered by Google App Engine
This is Rietveld 408576698