Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 13648007: Fix channel layout reporting for implicit signalling of AAC parametric stereo (Closed)

Created:
7 years, 8 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix channel layout reporting for implicit signalling of AAC parametric stereo BUG=226642 TEST=AACTest_TestImplicitSBR_ChannelConfig0,AACTest_TestImplicitSBR_ChannelConfig1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -11 lines) Patch
M media/mp4/aac.h View 1 chunk +7 lines, -1 line 0 comments Download
M media/mp4/aac.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M media/mp4/aac_unittest.cc View 4 chunks +33 lines, -5 lines 0 comments Download
M media/mp4/mp4_stream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
acolwell GONE FROM CHROMIUM
7 years, 8 months ago (2013-04-04 18:25:16 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 8 months ago (2013-04-04 20:36:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/13648007/1
7 years, 8 months ago (2013-04-04 20:54:14 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=6710
7 years, 8 months ago (2013-04-04 21:21:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/13648007/1
7 years, 8 months ago (2013-04-05 02:47:03 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 04:23:12 UTC) #6
Message was sent while issue was closed.
Change committed as 192498

Powered by Google App Engine
This is Rietveld 408576698