Issue 13648004: Fix silly bugs around overscan flag detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13648004: Fix silly bugs around overscan flag detection. (Closed)

Created:
7 years, 8 months ago by Jun Mukai

Modified:
7 years, 8 months ago

Reviewers:
Daniel Erat, oshima

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix silly bugs around overscan flag detection. - we want to check a data block of a specific tag and enough length, which doesn't mean && here. - data_block skipping length is different between two continue BUG=226318 TEST=ui_unittests passed Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192497

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	ui/base/x/x11_util.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	ui/base/x/x11_util_unittest.cc	View		2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/13648004/1

7 years, 8 months ago (2013-04-04 18:25:50 UTC) #5

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-04 18:30:57 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/13648004/1

7 years, 8 months ago (2013-04-04 22:23:32 UTC) #7

Message was sent while issue was closed.

Change committed as 192497

Expand Messages | Collapse Messages