Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 13647006: Move webview size information into RWHVGuest. (Closed)

Created:
7 years, 8 months ago by alexst (slow to review)
Modified:
7 years, 8 months ago
Reviewers:
Fady Samuel, lazyboy, piman
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, Fady Samuel
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move webview size information into RWHVGuest. Managing size information via the platform view has undesirable side effects. For instance in aura, calls to SetBounds cause the platform view to take resize locks, which are not needed for something that is displayed indirectly. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192626

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M content/browser/renderer_host/render_widget_host_view_guest.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.cc View 3 chunks +5 lines, -4 lines 1 comment Download
M content/browser/web_contents/web_contents_view_guest.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alexst (slow to review)
Istiaque, please take a look.
7 years, 8 months ago (2013-04-04 19:01:53 UTC) #1
Fady Samuel
Question: Do we still need a platform view for guests?
7 years, 8 months ago (2013-04-04 19:03:19 UTC) #2
Fady Samuel
Question: Do we still need a platform view for guests?
7 years, 8 months ago (2013-04-04 19:03:26 UTC) #3
lazyboy
lgtm re: Do we still need a platform view -> I believe so, they serve ...
7 years, 8 months ago (2013-04-04 19:29:42 UTC) #4
alexst (slow to review)
On 2013/04/04 19:03:26, Fady Samuel wrote: > Question: Do we still need a platform view ...
7 years, 8 months ago (2013-04-04 19:30:08 UTC) #5
alexst (slow to review)
Antoine, can you take a look when you have a moment. Thank you!
7 years, 8 months ago (2013-04-05 11:39:02 UTC) #6
piman
lgtm
7 years, 8 months ago (2013-04-05 16:36:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexst@chromium.org/13647006/1
7 years, 8 months ago (2013-04-05 16:41:21 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 20:29:06 UTC) #9
Message was sent while issue was closed.
Change committed as 192626

Powered by Google App Engine
This is Rietveld 408576698