app_shell: Make renderer run background page JavaScript

app_shell: Make renderer run background page JavaScript

* Install URL protocol handler for chrome-extension:// and chrome-extension-resource://
* Allow extension urls to be handled.
* Register extensions with IO thread extension InfoMap.
* Bonus: app_shell no longer crashes on startup.

With this change an extension background page can print "Hello world" using console.log().

BUG=288226, 332982
TEST=browser_tests. Also run app_shell --app=/path/to/extension with an extension with background.js. The JavaScript executes and console.log() works.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245325

[James Cook, 2014-01-15 18:49:27]

yoz, PTAL.  This patch gets us to Milestone 3.

https://codereview.chromium.org/136453005/diff/50001/apps/shell/shell_content...
File apps/shell/shell_content_browser_client.cc (right):

https://codereview.chromium.org/136453005/diff/50001/apps/shell/shell_content...
apps/shell/shell_content_browser_client.cc:51:
(*protocol_handlers)[extensions::kExtensionScheme] =
This is equivalent to the way Chrome registers these protocol handlers in
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...

[Yoyo Zhou, 2014-01-16 01:44:11]

LGTM

https://chromiumcodereview.appspot.com/136453005/diff/50001/apps/shell/shell_...
File apps/shell/shell_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/136453005/diff/50001/apps/shell/shell_...
apps/shell/shell_content_browser_client.cc:129: // service process map, or can
we assume all renderers are extension
Assuming this is probably ok until we learn otherwise. =) Good to document this
assumption though.

[commit-bot: I haz the power, 2014-01-16 17:37:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/136453005/50001

[commit-bot: I haz the power, 2014-01-16 21:23:49]

Change committed as 245325

[kirr, 2014-03-07 12:23:40]

https://codereview.chromium.org/136453005/diff/50001/chrome/browser/extension...
File chrome/browser/extensions/extension_host.cc (right):

https://codereview.chromium.org/136453005/diff/50001/chrome/browser/extension...
chrome/browser/extensions/extension_host.cc:196: if (!IsBackgroundPage()) {
Is it a misprint in condition? Seems like DidCreateRenderViewForBackgroundPage
is only for background pages.

[James Cook, 2014-03-07 17:14:47]

https://codereview.chromium.org/136453005/diff/50001/chrome/browser/extension...
File chrome/browser/extensions/extension_host.cc (right):

https://codereview.chromium.org/136453005/diff/50001/chrome/browser/extension...
chrome/browser/extensions/extension_host.cc:196: if (!IsBackgroundPage()) {
On 2014/03/07 12:23:40, kirr wrote:
> Is it a misprint in condition? Seems like DidCreateRenderViewForBackgroundPage
> is only for background pages.

Yeah, that looks wrong. I'm taking a closer look at the code now.  Is there a
bug you think is caused by this problem?