Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13643005: drive: Some cleanup for file_manager_browsertest.cc (Closed)

Created:
7 years, 8 months ago by satorux1
Modified:
7 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Some cleanup for file_manager_browsertest.cc This is in preparation for porting TestKeyboard* tests to Drive. - Move TestFilePathWatcher to before FileManagerBrowserLocalTest - Add GetRootPath(), PathExists(), WaitUntilFilePresentWithSize(), WaitUntilFileNotPresent() BUG=224534 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193085

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -122 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc View 1 2 9 chunks +188 lines, -122 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
satorux1
7 years, 8 months ago (2013-04-05 08:31:05 UTC) #1
kinaba
lgtm
7 years, 8 months ago (2013-04-05 08:33:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/13643005/9001
7 years, 8 months ago (2013-04-09 06:17:05 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-09 07:48:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/13643005/9001
7 years, 8 months ago (2013-04-09 07:51:14 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-09 09:18:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/13643005/9001
7 years, 8 months ago (2013-04-09 09:29:59 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 12:40:30 UTC) #8
Message was sent while issue was closed. 
Change committed as 193085

Powered by Google App Engine
This is Rietveld 408576698