blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java - Issue 1364143002: Move ChromeCommandLineInitUtil to base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java

Issue 1364143002: Move ChromeCommandLineInitUtil to base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_test

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/CommandLineInitUtil.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java

diff --git a/blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java b/blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java

index e5ca111d87c5516eb702afb205565f4ae90f6470..f25a12388c74d06b934af4409b8746f19daea640 100644

--- a/blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java

+++ b/blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java

@@ -7,6 +7,7 @@ package org.chromium.blimp;

import android.app.Application;

import org.chromium.base.BaseChromiumApplication;

+import org.chromium.base.CommandLineInitUtil;

import org.chromium.base.PathUtils;

import org.chromium.base.ResourceExtractor;

@@ -14,8 +15,8 @@ import org.chromium.base.ResourceExtractor;

* The {@link Application} for the Blimp client.

public class BlimpApplication extends BaseChromiumApplication {

+ private static final String COMMAND_LINE_FILE = "blimp-command-line";

nyquist 2015/09/24 16:41:15 Could you add a file //build/android/adb_blimp_com

David Trainor- moved to gerrit 2015/09/28 17:27:23 Done.

private static final String[] MANDATORY_PAK_FILES = new String[] {};

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "blimp";

@Override

@@ -24,4 +25,9 @@ public class BlimpApplication extends BaseChromiumApplication {

ResourceExtractor.setMandatoryPaksToExtract(MANDATORY_PAK_FILES);

PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX, this);

}

+ @Override

+ public void initCommandLine() {

nyquist 2015/09/24 16:41:15 Could you add documentation about how to use this

David Trainor- moved to gerrit 2015/09/28 17:27:23 Done.

+ CommandLineInitUtil.initCommandLine(this, COMMAND_LINE_FILE);

+ }

}