Move ChromeCommandLineInitUtil to base/

Move ChromeCommandLineInitUtil to base/

- Make ChromeCommandLineInitUtil accessible to other folders than chrome/.
- Pull out the command line file name to be passed as a parameter.

BUG=526219
Committed: https://crrev.com/ac84a37c07ae9377fcb7baed8791b76640f341a5
Cr-Commit-Position: refs/heads/master@{#352349}

[David Trainor- moved to gerrit, 2015-09-24 00:15:10]

dtrainor@chromium.org changed reviewers:
+ nyquist@chromium.org, yusufo@chromium.org

[David Trainor- moved to gerrit, 2015-09-24 00:15:11]

ptal thanks! :)

[Yusuf, 2015-09-24 04:58:22]

lgtm

[nyquist, 2015-09-24 16:41:15]

https://codereview.chromium.org/1364143002/diff/1/blimp/client/android/java/s...
File blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java
(right):

https://codereview.chromium.org/1364143002/diff/1/blimp/client/android/java/s...
blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java:18:
private static final String COMMAND_LINE_FILE = "blimp-command-line";
Could you add a file //build/android/adb_blimp_command_line that configures up
this file correctly?

https://codereview.chromium.org/1364143002/diff/1/blimp/client/android/java/s...
blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java:30:
public void initCommandLine() {
Could you add documentation about how to use this to the blimp documentation?

[David Trainor- moved to gerrit, 2015-09-28 17:27:23]

https://chromiumcodereview.appspot.com/1364143002/diff/1/blimp/client/android...
File blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java
(right):

https://chromiumcodereview.appspot.com/1364143002/diff/1/blimp/client/android...
blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java:18:
private static final String COMMAND_LINE_FILE = "blimp-command-line";
On 2015/09/24 16:41:15, nyquist wrote:
> Could you add a file //build/android/adb_blimp_command_line that configures up
> this file correctly?

Done.

https://chromiumcodereview.appspot.com/1364143002/diff/1/blimp/client/android...
blimp/client/android/java/src/org/chromium/blimp/BlimpApplication.java:30:
public void initCommandLine() {
On 2015/09/24 16:41:15, nyquist wrote:
> Could you add documentation about how to use this to the blimp documentation?

Done.

[nyquist, 2015-09-28 17:37:28]

https://chromiumcodereview.appspot.com/1364143002/diff/20001/blimp/client/and...
File blimp/client/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java
(right):

https://chromiumcodereview.appspot.com/1364143002/diff/20001/blimp/client/and...
blimp/client/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java:80: if
(sLoadAttempted) return;
This isn't really thread safe, and it's a |public static| method. Would we want
to add some sanity checks to the start of this method? Either something from
//base (ThreadUtils.assertOnUiThread()), or if we don't want more dependencies,
something like:
Looper.myLooper() == Looper.getMainLooper();

https://chromiumcodereview.appspot.com/1364143002/diff/20001/blimp/docs/runni...
File blimp/docs/running.md (right):

https://chromiumcodereview.appspot.com/1364143002/diff/20001/blimp/docs/runni...
blimp/docs/running.md:21: adb_blimp_command_line --enable-webgl
Should this be ./build/android/adb_climp_command_line ?
I don't think build/android is in the PATH? (same below)

[David Trainor- moved to gerrit, 2015-09-28 23:29:58]

updated.  ptal.

https://chromiumcodereview.appspot.com/1364143002/diff/20001/blimp/client/and...
File blimp/client/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java
(right):

https://chromiumcodereview.appspot.com/1364143002/diff/20001/blimp/client/and...
blimp/client/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java:80: if
(sLoadAttempted) return;
On 2015/09/28 17:37:27, nyquist wrote:
> This isn't really thread safe, and it's a |public static| method. Would we
want
> to add some sanity checks to the start of this method? Either something from
> //base (ThreadUtils.assertOnUiThread()), or if we don't want more
dependencies,
> something like:
> Looper.myLooper() == Looper.getMainLooper();

We already include base.  I'll just use assertOnUiThread().  Good call!

https://chromiumcodereview.appspot.com/1364143002/diff/20001/blimp/docs/runni...
File blimp/docs/running.md (right):

https://chromiumcodereview.appspot.com/1364143002/diff/20001/blimp/docs/runni...
blimp/docs/running.md:21: adb_blimp_command_line --enable-webgl
On 2015/09/28 17:37:27, nyquist wrote:
> Should this be ./build/android/adb_climp_command_line ?
> I don't think build/android is in the PATH? (same below)

Huh it auto-completes for me.  Will add though just to be safe and consistent.

[nyquist, 2015-09-29 23:12:56]

lgtm

[David Trainor- moved to gerrit, 2015-09-30 17:44:53]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2015-09-30 17:44:53]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1364143002/#ps80001
(title: "Made sure we actually initialize the command line")

[commit-bot: I haz the power, 2015-09-30 17:45:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364143002/80001

[commit-bot: I haz the power, 2015-09-30 17:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 17:52:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[David Trainor- moved to gerrit, 2015-09-30 18:55:24]

dtrainor@chromium.org changed reviewers:
+ jbudorick@chromium.org

[David Trainor- moved to gerrit, 2015-09-30 18:55:25]

Hey John!  Can you take a look at build/android?  I need an owners review. 
Thanks!

[David Trainor- moved to gerrit, 2015-10-02 20:23:45]

Friendly ping jbudorick@.  Thanks! :)

[jbudorick, 2015-10-02 22:36:52]

On 2015/10/02 20:23:45, David Trainor wrote:
> Friendly ping jbudorick@.  Thanks! :)

Time zones are hard.

lgtm

[David Trainor- moved to gerrit, 2015-10-05 14:58:02]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2015-10-05 14:58:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364143002/80001

[commit-bot: I haz the power, 2015-10-05 15:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 15:07:42]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Trainor- moved to gerrit, 2015-10-05 16:18:08]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2015-10-05 16:18:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364143002/80001

[commit-bot: I haz the power, 2015-10-05 18:01:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-05 18:02:56]

Patchset 5 (id:??) landed as
https://crrev.com/ac84a37c07ae9377fcb7baed8791b76640f341a5
Cr-Commit-Position: refs/heads/master@{#352349}