Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 13640006: Make csharp@ and maruel@ owners of .isolate files (Closed)

Created:
7 years, 8 months ago by csharp
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make csharp@ and maruel@ owners of .isolate files NOTRY=true R=maruel@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192635

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M base/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
csharp
7 years, 8 months ago (2013-04-04 15:38:27 UTC) #1
M-A Ruel
+Dirk I don't know if it'll work recursively.
7 years, 8 months ago (2013-04-04 15:40:17 UTC) #2
M-A Ruel
On 2013/04/04 15:40:17, Marc-Antoine Ruel wrote: > +Dirk > > I don't know if it'll ...
7 years, 8 months ago (2013-04-04 19:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/13640006/1
7 years, 8 months ago (2013-04-04 19:40:35 UTC) #4
commit-bot: I haz the power
Presubmit check for 13640006-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-04 19:40:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/13640006/1
7 years, 8 months ago (2013-04-04 19:41:49 UTC) #6
csharp
Update OWNERS files in the correct directories (skipped the thrid_party one to avoid creating a ...
7 years, 8 months ago (2013-04-04 20:04:08 UTC) #7
M-A Ruel
On 2013/04/04 20:04:08, csharp wrote: > Update OWNERS files in the correct directories (skipped the ...
7 years, 8 months ago (2013-04-04 20:07:30 UTC) #8
csharp
brettw@ and rsleevi@ for owner's approval, (Brief background, the isolate files will be used by ...
7 years, 8 months ago (2013-04-04 20:15:23 UTC) #9
Ryan Sleevi
lgtm
7 years, 8 months ago (2013-04-04 20:17:35 UTC) #10
Dirk Pranke
On 2013/04/04 15:40:17, Marc-Antoine Ruel wrote: > +Dirk > > I don't know if it'll ...
7 years, 8 months ago (2013-04-04 20:19:10 UTC) #11
brettw
lgtm
7 years, 8 months ago (2013-04-05 21:11:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/13640006/5002
7 years, 8 months ago (2013-04-05 21:15:46 UTC) #13
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 21:16:00 UTC) #14
Message was sent while issue was closed.
Change committed as 192635

Powered by Google App Engine
This is Rietveld 408576698