Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 13638013: Modifications to tests and test tools for Native Client V8. (Closed)

Created:
7 years, 8 months ago by Brad Chen
Modified:
7 years, 8 months ago
Reviewers:
ulan, danno, Jakob Kummerow
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Modifications to tests and test tools for Native Client V8. BUG=2614 Committed: https://code.google.com/p/v8/source/detail?r=14178

Patch Set 1 #

Patch Set 2 : Disable a test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -3 lines) Patch
M test/cctest/cctest.status View 1 1 chunk +13 lines, -0 lines 1 comment Download
M test/cctest/testcfg.py View 1 chunk +4 lines, -0 lines 0 comments Download
M test/message/testcfg.py View 1 chunk +7 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +31 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 chunk +5 lines, -1 line 0 comments Download
M tools/testrunner/local/statusfile.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Brad Chen
PTAL
7 years, 8 months ago (2013-04-05 21:06:22 UTC) #1
ulan
LGTM, will land after getting Jakob's approval.
7 years, 8 months ago (2013-04-09 07:41:54 UTC) #2
Jakob Kummerow
lgtm
7 years, 8 months ago (2013-04-09 08:09:28 UTC) #3
Jakob Kummerow
https://codereview.chromium.org/13638013/diff/3001/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/13638013/diff/3001/test/cctest/cctest.status#newcode105 test/cctest/cctest.status:105: test-sockets/Socket: SKIP Please make sure there's a newline at ...
7 years, 8 months ago (2013-04-09 08:11:43 UTC) #4
ulan
7 years, 8 months ago (2013-04-09 08:39:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698