Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 13637010: Android: Avoid multiple data file pushes for unittests (Closed)

Created:
7 years, 8 months ago by nilesh
Modified:
7 years, 8 months ago
Reviewers:
frankf
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Android: Avoid multiple data file pushes for unittests This also fixes failures in content_unittests and components_unittests when they are run separately. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193039

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase after zip files moved to components_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M build/android/pylib/gtest/test_runner.py View 1 4 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
nilesh
7 years, 8 months ago (2013-04-08 19:03:57 UTC) #1
frankf
https://codereview.chromium.org/13637010/diff/1/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (left): https://codereview.chromium.org/13637010/diff/1/build/android/pylib/gtest/test_runner.py#oldcode33 build/android/pylib/gtest/test_runner.py:33: if test_suite_basename in ['base_unittests', 'sql_unittests', 'unit_tests']: sql_unittests don't have ...
7 years, 8 months ago (2013-04-08 19:19:37 UTC) #2
nilesh
I will rebase with https://codereview.chromium.org/13467035/ and update the CL. https://codereview.chromium.org/13637010/diff/1/build/android/pylib/gtest/test_runner.py File build/android/pylib/gtest/test_runner.py (left): https://codereview.chromium.org/13637010/diff/1/build/android/pylib/gtest/test_runner.py#oldcode33 build/android/pylib/gtest/test_runner.py:33: ...
7 years, 8 months ago (2013-04-08 23:50:57 UTC) #3
nilesh
Rebased and created a section for components_unittests. Please take another look.
7 years, 8 months ago (2013-04-09 00:08:07 UTC) #4
frankf
So this needs to be tested by clobbering the device and using -c to clean ...
7 years, 8 months ago (2013-04-09 00:17:39 UTC) #5
nilesh
On 2013/04/09 00:17:39, frankf wrote: > So this needs to be tested by clobbering the ...
7 years, 8 months ago (2013-04-09 00:21:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/13637010/6001
7 years, 8 months ago (2013-04-09 00:36:31 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-09 01:02:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/13637010/6001
7 years, 8 months ago (2013-04-09 02:39:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/13637010/6001
7 years, 8 months ago (2013-04-09 02:42:34 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=100881
7 years, 8 months ago (2013-04-09 05:44:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/13637010/6001
7 years, 8 months ago (2013-04-09 06:33:37 UTC) #12
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 08:46:29 UTC) #13
Message was sent while issue was closed.
Change committed as 193039

Powered by Google App Engine
This is Rietveld 408576698