Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issue 13637009: Hide cursor upon lock animation (Closed)

Created:
7 years, 8 months ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years, 8 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Hide cursor upon lock animation BUG=173944 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192979

Patch Set 1 #

Patch Set 2 : Final attempt, with comments #

Total comments: 3

Patch Set 3 : Remove commented code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ash/wm/session_state_controller_impl2.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Denis Kuznetsov (DE-MUC)
Please use LGTM&CQ.
7 years, 8 months ago (2013-04-08 18:12:18 UTC) #1
Daniel Erat
https://chromiumcodereview.appspot.com/13637009/diff/2001/ash/wm/session_state_controller_impl2.cc File ash/wm/session_state_controller_impl2.cc (right): https://chromiumcodereview.appspot.com/13637009/diff/2001/ash/wm/session_state_controller_impl2.cc#newcode267 ash/wm/session_state_controller_impl2.cc:267: //ash::Shell::GetInstance()->cursor_manager()->ShowCursor(); what did you plan to do with this? ...
7 years, 8 months ago (2013-04-08 18:39:49 UTC) #2
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/13637009/diff/2001/ash/wm/session_state_controller_impl2.cc File ash/wm/session_state_controller_impl2.cc (right): https://chromiumcodereview.appspot.com/13637009/diff/2001/ash/wm/session_state_controller_impl2.cc#newcode267 ash/wm/session_state_controller_impl2.cc:267: //ash::Shell::GetInstance()->cursor_manager()->ShowCursor(); On 2013/04/08 18:39:49, Daniel Erat wrote: > what ...
7 years, 8 months ago (2013-04-08 18:44:49 UTC) #3
Daniel Erat
lgtm https://chromiumcodereview.appspot.com/13637009/diff/2001/ash/wm/session_state_controller_impl2.cc File ash/wm/session_state_controller_impl2.cc (right): https://chromiumcodereview.appspot.com/13637009/diff/2001/ash/wm/session_state_controller_impl2.cc#newcode267 ash/wm/session_state_controller_impl2.cc:267: //ash::Shell::GetInstance()->cursor_manager()->ShowCursor(); On 2013/04/08 18:44:49, Denis Kuznetsov wrote: > ...
7 years, 8 months ago (2013-04-08 19:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/13637009/5004
7 years, 8 months ago (2013-04-08 19:28:36 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 01:40:10 UTC) #6
Message was sent while issue was closed.
Change committed as 192979

Powered by Google App Engine
This is Rietveld 408576698