chrome/browser/safe_browsing/incident_reporting/incident.h - Issue 1363613004: Implement anonymous, opt-in, collection of OS X binary integrity incidents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident.h

Issue 1363613004: Implement anonymous, opt-in, collection of OS X binary integrity incidents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/osx_binary_integrity_incident.h » ('j') | chrome/browser/safe_browsing/incident_reporting/osx_binary_integrity_incident.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident.h b/chrome/browser/safe_browsing/incident_reporting/incident.h

index 2fa84c9cfb8bf8fef20a249baaae7c2b50c50518..7c8b888de16c092d7b1c1415722d89eca5b26f7a 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident.h

+++ b/chrome/browser/safe_browsing/incident_reporting/incident.h

@@ -27,8 +27,9 @@ enum class IncidentType : int32_t {

OMNIBOX_INTERACTION = 4,

VARIATIONS_SEED_SIGNATURE = 5,

RESOURCE_REQUEST = 6,

+ OSX_INCIDENT = 7,

grt (UTC plus 2) 2015/10/03 20:03:00 why not generalize BINARY_INTEGRITY so that it's s

Greg K 2015/10/07 22:54:29 Done.

// Values for new incident types go here.

- NUM_TYPES = 7

+ NUM_TYPES = 8

};

// An abstract incident. Subclasses provide type-specific functionality to