Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1363023005: Implement FullScreen using top layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 228996e93fc80f3cb8fd10e19484bc1180d0ac76..c87a664e7b2d39354b82fdcd230a11befafb4e3c 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -63,7 +63,6 @@
#include "core/html/HTMLMediaElement.h"
#include "core/input/EventHandler.h"
#include "core/layout/HitTestResult.h"
-#include "core/layout/LayoutFullScreen.h"
#include "core/layout/LayoutView.h"
#include "core/layout/compositing/DeprecatedPaintLayerCompositor.h"
#include "core/loader/DocumentLoader.h"
@@ -6486,7 +6485,8 @@ TEST_P(ParameterizedWebFrameTest, FullscreenLayerSize)
ASSERT_TRUE(Fullscreen::isFullScreen(*document));
// Verify that the element is sized to the viewport.
- LayoutFullScreen* fullscreenLayoutObject = Fullscreen::from(*document).fullScreenLayoutObject();
+ Element* fullscreenElement = Fullscreen::currentFullScreenElementFrom(*document);
+ LayoutBox* fullscreenLayoutObject = toLayoutBox(fullscreenElement->layoutObject());
EXPECT_EQ(viewportWidth, fullscreenLayoutObject->logicalWidth().toInt());
EXPECT_EQ(viewportHeight, fullscreenLayoutObject->logicalHeight().toInt());
@@ -6590,7 +6590,8 @@ TEST_P(ParameterizedWebFrameTest, FullscreenSubframe)
webViewImpl->layout();
// Verify that the element is sized to the viewport.
- LayoutFullScreen* fullscreenLayoutObject = Fullscreen::from(*document).fullScreenLayoutObject();
+ Element* fullscreenElement = Fullscreen::currentFullScreenElementFrom(*document);
+ LayoutBox* fullscreenLayoutObject = toLayoutBox(fullscreenElement->layoutObject());
EXPECT_EQ(viewportWidth, fullscreenLayoutObject->logicalWidth().toInt());
EXPECT_EQ(viewportHeight, fullscreenLayoutObject->logicalHeight().toInt());

Powered by Google App Engine
This is Rietveld 408576698