Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 13625002: Change the behavior of the [X] Save details to Wallet checkbox notification to: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index 6c887043d3dea37628c92d1160fd3235e68dcdf5..d6f7a5aa72309ca4ab0dc7713a8cce083ddb226c 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -140,6 +140,8 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
virtual std::vector<DialogNotification> CurrentNotifications() const OVERRIDE;
virtual void StartSignInFlow() OVERRIDE;
virtual void EndSignInFlow() OVERRIDE;
+ virtual void NotificationCheckboxStateChanged(DialogNotification::Type type,
+ bool checked) OVERRIDE;
virtual void LegalDocumentLinkClicked(const ui::Range& range) OVERRIDE;
virtual void OnCancel() OVERRIDE;
virtual void OnAccept() OVERRIDE;
@@ -246,6 +248,9 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// Returns whether Wallet is the current data source. Exposed for testing.
virtual bool IsPayingWithWallet() const;
+ // Exposed and virtual for testing.
+ virtual bool IsFirstRun() const;
+
private:
// Whether or not the current request wants credit info back.
bool RequestingCreditCardInfo() const;
@@ -254,9 +259,6 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// to the requesting site.
bool TransmissionWillBeSecure() const;
- // Whether the user has ever seen this dialog before. Cancels don't count.
- bool IsFirstRun() const;
-
// Initializes |suggested_email_| et al.
void SuggestionsUpdated();
@@ -268,8 +270,8 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// Whether the user's wallet items have at least one address and instrument.
bool HasCompleteWallet() const;
- // Starts fetching the wallet items.
- void StartFetchingWalletItems();
+ // Starts fetching the wallet items from Online Wallet.
+ void GetWalletItems();
// Refreshes the model on Wallet or sign-in state update.
void OnWalletOrSigninUpdate();
@@ -485,6 +487,9 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// Whether this is an Autocheckout or a requestAutocomplete dialog.
const DialogType dialog_type_;
+ // Whether this is the first time this profile has seen the Autofill dialog.
+ bool is_first_run_;
+
// True after the user first accepts the dialog and presses "Submit". May
// continue to be true while processing required actions.
bool is_submitting_;
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller.h ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698