chrome/browser/metrics/variations/resource_request_allowed_notifier_test_util.h - Issue 13620010: Refactor ResourceRequestAllowedNotifier EULA checking into a separate class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/resource_request_allowed_notifier_test_util.h

Issue 13620010: Refactor ResourceRequestAllowedNotifier EULA checking into a separate class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/variations/resource_request_allowed_notifier.cc ('k') | chrome/browser/metrics/variations/resource_request_allowed_notifier_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/resource_request_allowed_notifier_test_util.h

===================================================================

--- chrome/browser/metrics/variations/resource_request_allowed_notifier_test_util.h (revision 192635)

+++ chrome/browser/metrics/variations/resource_request_allowed_notifier_test_util.h (working copy)

@@ -21,9 +21,10 @@

TestRequestAllowedNotifier();

virtual ~TestRequestAllowedNotifier();

-#if defined(OS_CHROMEOS)

- void SetNeedsEulaAcceptance(bool needs_acceptance);

-#endif

+ // A version of |Init()| that accepts a custom EulaAcceptedNotifier.

+ void InitWithEulaAcceptNotifier(

+ Observer* observer,

+ scoped_ptr<EulaAcceptedNotifier> eula_notifier);

// Makes ResourceRequestsAllowed return |allowed| when it is called.

void SetRequestsAllowedOverride(bool allowed);

@@ -32,17 +33,12 @@

// the observer is expecting a notification.

void NotifyObserver();

+ // ResourceRequestAllowedNotifier overrides:

virtual bool ResourceRequestsAllowed() OVERRIDE;

+ virtual EulaAcceptedNotifier* CreateEulaNotifier() OVERRIDE;

- protected:

-#if defined(OS_CHROMEOS)

- virtual bool NeedsEulaAcceptance() OVERRIDE;

-#endif

private:

-#if defined(OS_CHROMEOS)

- bool needs_eula_acceptance_;

-#endif

+ scoped_ptr<EulaAcceptedNotifier> test_eula_notifier_;

bool override_requests_allowed_;

bool requests_allowed_;