Migrate window.localStorage settings to chrome.storage.local at start-up.

Migrate window.localStorage settings to chrome.storage.local at start-up.

This ensures that users don't lose any saved settings when upgrading to M27.

BUG=226488
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192494

[Jamie, 2013-04-04 18:04:03]

ptal

[Wez, 2013-04-04 18:51:40]

lgtm

https://codereview.chromium.org/13619010/diff/1/remoting/webapp/remoting.js
File remoting/webapp/remoting.js (right):

https://codereview.chromium.org/13619010/diff/1/remoting/webapp/remoting.js#n...
remoting/webapp/remoting.js:37: migrateSettings_();
nit: migrateLocalToChromeStorage_()?

https://codereview.chromium.org/13619010/diff/1/remoting/webapp/remoting.js#n...
remoting/webapp/remoting.js:364: // those settings.
nit: I'd suggest rewording to explain that we're migrating all settings from
localStorage to chrome.storage.local, except for the OAuth2 settings.

https://codereview.chromium.org/13619010/diff/1/remoting/webapp/remoting.js#n...
remoting/webapp/remoting.js:376: chrome.storage.local.set(copy);
nit: You could collate the values to copy and do a single set(), and then run a
second iteration, this time over the copy object, deleting the values from
localStorage.

[Jamie, 2013-04-04 19:23:39]

fyi

https://codereview.chromium.org/13619010/diff/1/remoting/webapp/remoting.js
File remoting/webapp/remoting.js (right):

https://codereview.chromium.org/13619010/diff/1/remoting/webapp/remoting.js#n...
remoting/webapp/remoting.js:37: migrateSettings_();
On 2013/04/04 18:51:40, Wez wrote:
> nit: migrateLocalToChromeStorage_()?

Done.

https://codereview.chromium.org/13619010/diff/1/remoting/webapp/remoting.js#n...
remoting/webapp/remoting.js:364: // those settings.
On 2013/04/04 18:51:40, Wez wrote:
> nit: I'd suggest rewording to explain that we're migrating all settings from
> localStorage to chrome.storage.local, except for the OAuth2 settings.

I've added a doc comment to the function to explain its purpose.

https://codereview.chromium.org/13619010/diff/1/remoting/webapp/remoting.js#n...
remoting/webapp/remoting.js:376: chrome.storage.local.set(copy);
On 2013/04/04 18:51:40, Wez wrote:
> nit: You could collate the values to copy and do a single set(), and then run
a
> second iteration, this time over the copy object, deleting the values from
> localStorage.

I don't think that would be any clearer.

[commit-bot: I haz the power, 2013-04-04 19:23:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/13619010/5001

[commit-bot: I haz the power, 2013-04-04 19:26:51]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-04 22:47:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/13619010/5001

[commit-bot: I haz the power, 2013-04-04 22:54:35]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-05 00:36:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/13619010/5001

[commit-bot: I haz the power, 2013-04-05 04:12:54]

Change committed as 192494