Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 13614002: Use last_selected_directory() when invalid path is passed to CrOS file picker. (Closed)

Created:
7 years, 8 months ago by kinaba
Modified:
7 years, 8 months ago
Reviewers:
hashimoto, sky
CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Use last_selected_directory() when invalid path is passed to CrOS file picker. This is for working around the case when <input type="file"/> control is used twice; CrOS file picker kindly resolves a remote file path to a local cache and the type=file control tries to default to the path, but the cache path itself is out of user-visible directory. In such a case, we just use the last_selected_directory(), rather than going back to the very default directory. BUG=178013 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192492

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinaba
Could you take a look? +hashimoto: who knows well about Drive path resolution. +sky: as ...
7 years, 8 months ago (2013-04-04 05:11:07 UTC) #1
hashimoto
lgtm
7 years, 8 months ago (2013-04-04 05:23:51 UTC) #2
sky
Does this impact windows at all?
7 years, 8 months ago (2013-04-04 15:50:37 UTC) #3
kinaba
On 2013/04/04 15:50:37, sky wrote: > Does this impact windows at all? No, it doesn't. ...
7 years, 8 months ago (2013-04-04 22:53:08 UTC) #4
sky
LGTM
7 years, 8 months ago (2013-04-04 23:07:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/13614002/2001
7 years, 8 months ago (2013-04-04 23:09:22 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 04:03:40 UTC) #7
Message was sent while issue was closed.
Change committed as 192492

Powered by Google App Engine
This is Rietveld 408576698