Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5771)

Unified Diff: chrome/browser/gpu/three_d_api_observer.cc

Issue 1361253002: Separate the URL of an infobar link with clicking on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ios Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gpu/three_d_api_observer.cc
diff --git a/chrome/browser/gpu/three_d_api_observer.cc b/chrome/browser/gpu/three_d_api_observer.cc
index a12c777abaa2663b6255594dac03f42c21e3fb8e..b8bb56fd2df02bac7019ffb93bfb8791e0cc8023 100644
--- a/chrome/browser/gpu/three_d_api_observer.cc
+++ b/chrome/browser/gpu/three_d_api_observer.cc
@@ -46,7 +46,7 @@ class ThreeDAPIInfoBarDelegate : public ConfirmInfoBarDelegate {
bool Accept() override;
bool Cancel() override;
base::string16 GetLinkText() const override;
- bool LinkClicked(WindowOpenDisposition disposition) override;
+ GURL GetLinkURL() const override;
GURL url_;
content::ThreeDAPIType requester_;
@@ -149,17 +149,10 @@ base::string16 ThreeDAPIInfoBarDelegate::GetLinkText() const {
return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
}
-bool ThreeDAPIInfoBarDelegate::LinkClicked(WindowOpenDisposition disposition) {
- InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(
- content::OpenURLParams(
- GURL("https://support.google.com/chrome/?p=ib_webgl"),
- content::Referrer(),
- (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
- ui::PAGE_TRANSITION_LINK, false));
- return false;
+GURL ThreeDAPIInfoBarDelegate::GetLinkURL() const {
+ return GURL("https://support.google.com/chrome/?p=ib_webgl");
}
-
Peter Kasting 2015/10/01 00:10:58 Nit: Leave this blank line
Avi (use Gerrit) 2015/10/01 00:20:33 Done.
// ThreeDAPIObserver ----------------------------------------------------------
ThreeDAPIObserver::ThreeDAPIObserver() {

Powered by Google App Engine
This is Rietveld 408576698