chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc - Issue 1361253002: Separate the URL of an infobar link with clicking on it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc

Issue 1361253002: Separate the URL of an infobar link with clicking on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pkasting Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/obsolete_system_infobar_delegate.h ('k') | components/autofill/core/browser/autofill_cc_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc

diff --git a/chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc b/chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc

index 233451f423bd548dc72cc7a180803c609f70bfa6..379f62ed6907c0aa3519ba57a591dd7938e05692 100644

--- a/chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc

+++ b/chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc

@@ -54,17 +54,10 @@ base::string16 ObsoleteSystemInfoBarDelegate::GetLinkText() const {

return l10n_util::GetStringUTF16(IDS_LEARN_MORE);

}

-bool ObsoleteSystemInfoBarDelegate::LinkClicked(

- WindowOpenDisposition disposition) {

- InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(

- content::OpenURLParams(

+GURL ObsoleteSystemInfoBarDelegate::GetLinkURL() const {

#if defined(OS_MACOSX)

- GURL(chrome::kMac32BitDeprecationURL),

+ return GURL(chrome::kMac32BitDeprecationURL);

#else

- GURL("https://support.google.com/chrome/answer/95411"),

+ return GURL("https://support.google.com/chrome/answer/95411");

#endif

- content::Referrer(),

- (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,

- ui::PAGE_TRANSITION_LINK, false));

- return false;

}