chrome/browser/renderer_context_menu/spelling_bubble_model.cc - Issue 1361253002: Separate the URL of an infobar link with clicking on it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spelling_bubble_model.cc

Issue 1361253002: Separate the URL of an infobar link with clicking on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pkasting Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_bubble_model.h ('k') | chrome/browser/ui/autofill/chrome_autofill_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spelling_bubble_model.cc

diff --git a/chrome/browser/renderer_context_menu/spelling_bubble_model.cc b/chrome/browser/renderer_context_menu/spelling_bubble_model.cc

index 3c179d0c6cef79b28f168c765f0ec30c419583d2..a387134ae6fbc8630735f887d49b7e0117ef6b24 100644

--- a/chrome/browser/renderer_context_menu/spelling_bubble_model.cc

+++ b/chrome/browser/renderer_context_menu/spelling_bubble_model.cc

@@ -59,10 +59,13 @@ base::string16 SpellingBubbleModel::GetLinkText() const {

return l10n_util::GetStringUTF16(IDS_LEARN_MORE);

}

+GURL SpellingBubbleModel::GetLinkURL() const {

+ return GURL(chrome::kPrivacyLearnMoreURL);

void SpellingBubbleModel::LinkClicked() {

- OpenURLParams params(

- GURL(chrome::kPrivacyLearnMoreURL), Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK, false);

+ OpenURLParams params(GetLinkURL(), Referrer(), NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

web_contents_->OpenURL(params);

}