Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 13610005: Prevent loading of component extensions in kiosk mode. (Closed)

Created:
7 years, 8 months ago by zel
Modified:
7 years, 8 months ago
Reviewers:
xiyuan, Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Prevent loading of component extensions in kiosk mode. On the selected kiosk app runs in this mode, so we don't need any system UI including component extensions/apps. BUG=227314 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/extensions/extension_system.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
zel
7 years, 8 months ago (2013-04-06 03:26:22 UTC) #1
xiyuan
This also skips ChromeVox. Would this be fine?
7 years, 8 months ago (2013-04-06 03:40:02 UTC) #2
zel
Yeah, I think so. There are no other accessibility features in this mode either. In ...
7 years, 8 months ago (2013-04-06 05:45:12 UTC) #3
xiyuan
LGTM
7 years, 8 months ago (2013-04-06 16:07:41 UTC) #4
Matt Perry
LGTM It would be good to include a reason for this in the bug. Also, ...
7 years, 8 months ago (2013-04-08 19:41:38 UTC) #5
zel
On 2013/04/08 19:41:38, Matt Perry wrote: > LGTM > > It would be good to ...
7 years, 8 months ago (2013-04-08 20:13:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/13610005/1
7 years, 8 months ago (2013-04-08 20:13:55 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 04:48:15 UTC) #8
Message was sent while issue was closed.
Change committed as 193009

Powered by Google App Engine
This is Rietveld 408576698