Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 13609003: fullscreen in apps v2 ShellWindow via app.window.create. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index f6213bebc1a7ecd24d79bbee873283f27f74be2a..1f726db950869721bfeacc309dadf83f108de687 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -211,6 +211,23 @@ bool AppWindowCreateFunction::RunImpl() {
if (options->resizable.get())
create_params.resizable = *options->resizable.get();
+
+ if (options->type != extensions::api::app_window::WINDOW_TYPE_PANEL) {
+ switch (options->state) {
+ case extensions::api::app_window::STATE_NONE:
+ case extensions::api::app_window::STATE_NORMAL:
+ break;
+ case extensions::api::app_window::STATE_FULLSCREEN:
+ create_params.state = ShellWindow::CreateParams::STATE_FULLSCREEN;
+ break;
+ case extensions::api::app_window::STATE_MAXIMIZED:
+ create_params.state = ShellWindow::CreateParams::STATE_MAXIMIZED;
+ break;
+ case extensions::api::app_window::STATE_MINIMIZED:
+ create_params.state = ShellWindow::CreateParams::STATE_MINIMIZED;
+ break;
+ }
+ }
}
create_params.creator_process_id =
@@ -220,7 +237,7 @@ bool AppWindowCreateFunction::RunImpl() {
ShellWindow::Create(profile(), GetExtension(), url, create_params);
if (chrome::ShouldForceFullscreenApp())
- shell_window->GetBaseWindow()->SetFullscreen(true);
+ shell_window->Fullscreen();
content::RenderViewHost* created_view =
shell_window->web_contents()->GetRenderViewHost();

Powered by Google App Engine
This is Rietveld 408576698