chrome/browser/ui/views/external_tab_container_win.h - Issue 13609002: fix a problem that android cannot download files with basic authentication

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/external_tab_container_win.h

Issue 13609002: fix a problem that android cannot download files with basic authentication (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adding a call in http_transactions to get the auth info Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/instant_loader.cc ('k') | chrome/browser/ui/views/external_tab_container_win.cc » ('j') | net/http/http_network_transaction.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/external_tab_container_win.h

diff --git a/chrome/browser/ui/views/external_tab_container_win.h b/chrome/browser/ui/views/external_tab_container_win.h

index 185f45860b07b066f9bbd0091d2db192e13f663b..26ca3bf7780135e2c9857aff214f6fa6b8624f9f 100644

--- a/chrome/browser/ui/views/external_tab_container_win.h

+++ b/chrome/browser/ui/views/external_tab_container_win.h

@@ -128,6 +128,7 @@ class ExternalTabContainerWin : public ExternalTabContainer,

virtual bool TakeFocus(content::WebContents* source, bool reverse) OVERRIDE;

virtual bool CanDownload(content::RenderViewHost* render_view_host,

int request_id,

+ bool has_auth,

const std::string& request_method) OVERRIDE;

virtual bool OnGoToEntryOffset(int offset) OVERRIDE;

virtual bool HandleContextMenu(

« no previous file with comments | « chrome/browser/ui/search/instant_loader.cc ('k') | chrome/browser/ui/views/external_tab_container_win.cc » ('j') | net/http/http_network_transaction.h » ('J')