chrome/browser/android/chrome_web_contents_delegate_android.cc - Issue 13609002: fix a problem that android cannot download files with basic authentication

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_web_contents_delegate_android.cc

Issue 13609002: fix a problem that android cannot download files with basic authentication (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adding a call in http_transactions to get the auth info Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/chrome_web_contents_delegate_android.h ('k') | chrome/browser/download/download_request_limiter.h » ('j') | net/http/http_network_transaction.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_web_contents_delegate_android.cc

diff --git a/chrome/browser/android/chrome_web_contents_delegate_android.cc b/chrome/browser/android/chrome_web_contents_delegate_android.cc

index 56f993d5ba30e2dca8e4308b2b891dbe94b6e969..3e439a7bff48085662a695b77fc658146f0cbdbe 100644

--- a/chrome/browser/android/chrome_web_contents_delegate_android.cc

+++ b/chrome/browser/android/chrome_web_contents_delegate_android.cc

@@ -231,8 +231,9 @@ ChromeWebContentsDelegateAndroid::GetJavaScriptDialogManager() {

bool ChromeWebContentsDelegateAndroid::CanDownload(

content::RenderViewHost* source,

int request_id,

- const std::string& request_method) {

- if (request_method == net::HttpRequestHeaders::kGetMethod) {

+ const std::string& request_method,

+ bool has_auth) {

+ if (request_method == net::HttpRequestHeaders::kGetMethod && !has_auth) {

content::DownloadControllerAndroid::Get()->CreateGETDownload(

source, request_id);

return false;