Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 13608006: Implement new methods other than ContinueGetResourceList for FakeDriveService. (Closed)

Created:
7 years, 8 months ago by hidehiko
Modified:
7 years, 8 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement new methods other than ContinueGetResourceList for FakeDriveService. This CL implements five newly introduced methods on FakeDriveService. The implementation of ContinueGetResourceList, the remaining method, needs slightly more changes, so it will be done in another CL. The new methods will be used for testing of replacing GetResourceList method. BUG=160932 TEST=Ran unit_tests --gtest_filter=FakeDriveService* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -10 lines) Patch
M chrome/browser/google_apis/fake_drive_service.cc View 5 chunks +25 lines, -10 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service_unittest.cc View 1 chunk +324 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 8 months ago (2013-04-05 06:00:38 UTC) #1
kinaba
lgtm
7 years, 8 months ago (2013-04-05 06:51:55 UTC) #2
hashimoto
lgtm
7 years, 8 months ago (2013-04-05 07:31:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13608006/1
7 years, 8 months ago (2013-04-05 07:37:07 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 10:45:21 UTC) #5
Message was sent while issue was closed.
Change committed as 192544

Powered by Google App Engine
This is Rietveld 408576698