Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 13606002: Making touch target wider (35px) for the splitter in bookmark manager (Closed)

Created:
7 years, 8 months ago by varkha
Modified:
7 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Making touch target wider (35px) for the splitter in bookmark manager BUG=100083 TEST=Open bookmark manager on a touch device (such as Pixel). Confirm that the vertical splitter can be comfortably moved and tree pane resized for reasonably long folder names to fit. Repeat with a RTL language, e.g. by running "chrome --lang=IW" confirming that the left and right padding is reversed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192585

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/resources/bookmark_manager/css/bmm.css View 2 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
varkha
Kuscher@ reviewed the look of the splitter. Please review.
7 years, 8 months ago (2013-04-04 00:52:50 UTC) #1
Evan Stade
https://codereview.chromium.org/13606002/diff/1/chrome/browser/resources/bookmark_manager/css/bmm.css File chrome/browser/resources/bookmark_manager/css/bmm.css (right): https://codereview.chromium.org/13606002/diff/1/chrome/browser/resources/bookmark_manager/css/bmm.css#newcode251 chrome/browser/resources/bookmark_manager/css/bmm.css:251: border-left: 15px solid white; why white and not transparent?
7 years, 8 months ago (2013-04-04 02:37:57 UTC) #2
varkha
Transparent would make it blue (the color of the middle part of the splitter) and ...
7 years, 8 months ago (2013-04-04 03:16:30 UTC) #3
Evan Stade
lgtm
7 years, 8 months ago (2013-04-04 03:20:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/13606002/1
7 years, 8 months ago (2013-04-04 03:50:47 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 03:54:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/13606002/1
7 years, 8 months ago (2013-04-05 13:36:02 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 16:59:40 UTC) #8
Message was sent while issue was closed.
Change committed as 192585

Powered by Google App Engine
This is Rietveld 408576698