[Autofill] Give the PasswordAutofillAgent first shot at handling mouse events.

[Autofill] Give the PasswordAutofillAgent first shot at handling mouse events.

BUG=178313
TEST=(see instructions in bug)


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192538

[csharp, 2013-04-04 13:11:39]

LGTM

Does this bug affect the new UI as well?

[Ilya Sherman, 2013-04-04 21:54:28]

On 2013/04/04 13:11:39, csharp wrote:
> LGTM
> 
> Does this bug affect the new UI as well?

Yep, this fix is primarily targeting the new UI.  The old UI managed to more or
less handle this case by accident: it would show regular autocomplete
suggestions, but then treat them as password suggestions when the user clicked
on them.

[commit-bot: I haz the power, 2013-04-04 21:54:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/13601005/6001

[commit-bot: I haz the power, 2013-04-04 21:54:38]

Failed to apply patch for
components/autofill/renderer/password_autofill_manager.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/autofill/renderer/password_autofill_manager.cc
  Hunk #1 FAILED at 335.
  1 out of 1 hunk FAILED -- saving rejects to file
components/autofill/renderer/password_autofill_manager.cc.rej

Patch:       components/autofill/renderer/password_autofill_manager.cc
Index: components/autofill/renderer/password_autofill_manager.cc
diff --git a/components/autofill/renderer/password_autofill_manager.cc
b/components/autofill/renderer/password_autofill_manager.cc
index
1ab3d591991db7e46c64be9c504fc3e023b6640f..b127aea3d989d886ac06214ad2e6f4b60f04d02c
100644
--- a/components/autofill/renderer/password_autofill_manager.cc
+++ b/components/autofill/renderer/password_autofill_manager.cc
@@ -335,6 +335,16 @@ bool PasswordAutofillManager::DidClearAutofillSelection(
   return FindLoginInfo(node, &input, &password);
 }
 
+bool PasswordAutofillManager::ShowSuggestions(
+    const WebKit::WebInputElement& element) {
+  LoginToPasswordInfoMap::const_iterator iter =
+      login_to_password_info_.find(element);
+  if (iter == login_to_password_info_.end())
+    return false;
+
+  return ShowSuggestionPopup(iter->second.fill_data, element);
+}
+
 void PasswordAutofillManager::SendPasswordForms(WebKit::WebFrame* frame,
                                                 bool only_visible) {
   // Make sure that this security origin is allowed to use password manager.

[commit-bot: I haz the power, 2013-04-05 01:18:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/13601005/12001

[commit-bot: I haz the power, 2013-04-05 01:37:23]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-05 03:48:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/13601005/29001

[commit-bot: I haz the power, 2013-04-05 09:56:19]

Change committed as 192538