Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 13600003: Base Security: fix-up overflow tests (Closed)

Created:
7 years, 8 months ago by jln (very slow on Chromium)
Modified:
7 years, 8 months ago
Reviewers:
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Base Security: fix-up overflow tests - Let NewOverflow compile on Windows for the most part - Strengthen the compiler barrier on GCC compatible compilers This is a re-land of https://codereview.chromium.org/13460015/ with the Windows test kept disabled for now. BUG=174947 NOTRY=true TBR=jschuh Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M base/security_unittest.cc View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jln (very slow on Chromium)
Relanding https://codereview.chromium.org/13460015, TBR-ing jschuh.
7 years, 8 months ago (2013-04-04 00:38:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/13600003/1
7 years, 8 months ago (2013-04-04 00:39:18 UTC) #2
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 12:02:37 UTC) #3
Message was sent while issue was closed.
Change committed as 192310

Powered by Google App Engine
This is Rietveld 408576698