Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13599004: Fix some low hanging inefficiencies in the docs server (Closed)

Created:
7 years, 8 months ago by not at google - send to devlin
Modified:
7 years, 8 months ago
Reviewers:
cduvall
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix some low hanging inefficiencies in the docs server. Two of the most expensive operations (by profiling), apart from the template rendering itself, are calling UnixName (model.py) and removing comments from JSON files (json_comment_eater.py). This rewrites both and memoizes the former. BUG=227490 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193334

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : memoized -> memoize #

Patch Set 4 : fix bug in UnixName #

Patch Set 5 : move json_comment_eater to own dir, write test #

Patch Set 6 : better escape tests #

Patch Set 7 : object store creator test was broken #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -69 lines) Patch
M chrome/common/extensions/docs/server2/build_server.py View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/compiled_file_system_test.py View 1 2 3 4 5 6 7 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/server2/object_store_creator_test.py View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/preview.py View 1 2 3 4 4 chunks +12 lines, -3 lines 0 comments Download
M tools/json_comment_eater.py View 1 2 3 4 1 chunk +0 lines, -40 lines 0 comments Download
A tools/json_comment_eater/everything.json View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A tools/json_comment_eater/everything_expected.json View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A tools/json_comment_eater/json_comment_eater.py View 1 2 3 4 1 chunk +60 lines, -0 lines 0 comments Download
A tools/json_comment_eater/json_comment_eater_test.py View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/json_parse.py View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
A tools/json_schema_compiler/memoize.py View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/model.py View 1 2 3 2 chunks +20 lines, -10 lines 0 comments Download
M tools/json_to_struct/json_to_struct.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
not at google - send to devlin
On my mac, this makes integration tests take 1:39, down from 1:53. Not a huge ...
7 years, 8 months ago (2013-04-08 06:33:31 UTC) #1
cduvall
lgtm. Are there tests for json_comment_eater/unix_name?
7 years, 8 months ago (2013-04-09 17:46:39 UTC) #2
not at google - send to devlin
On 2013/04/09 17:46:39, cduvall wrote: > lgtm. Are there tests for json_comment_eater/unix_name? Unix name yes, ...
7 years, 8 months ago (2013-04-09 22:39:18 UTC) #3
not at google - send to devlin
tests done. comment without an lgtm if you want to interrupt the cq.
7 years, 8 months ago (2013-04-10 02:22:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/13599004/25001
7 years, 8 months ago (2013-04-10 02:22:59 UTC) #5
commit-bot: I haz the power
Presubmit check for 13599004-25001 failed and returned exit status 1. INFO:root:Found 10 file(s). testGetBranchNumberForChannelName (__main__.BranchUtilityTest) ...
7 years, 8 months ago (2013-04-10 02:24:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/13599004/30001
7 years, 8 months ago (2013-04-10 02:40:08 UTC) #7
commit-bot: I haz the power
Presubmit check for 13599004-30001 failed and returned exit status 1. INFO:root:Found 11 file(s). testGetBranchNumberForChannelName (__main__.BranchUtilityTest) ...
7 years, 8 months ago (2013-04-10 02:41:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/13599004/34001
7 years, 8 months ago (2013-04-10 02:49:41 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101572
7 years, 8 months ago (2013-04-10 04:55:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/13599004/34001
7 years, 8 months ago (2013-04-10 05:03:21 UTC) #11
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 06:31:10 UTC) #12
Message was sent while issue was closed. 
Change committed as 193334

Powered by Google App Engine
This is Rietveld 408576698