Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 13599003: revoke unused OAuth2 tokens on signout and re-signin (Closed)

Created:
7 years, 8 months ago by Michael Courage
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

revoke unused OAuth2 tokens on signout and re-signin A number of users have been reporting problems with the identity API. Gaia investigations reveal that these users have overflowed a limit on the number of login tokens they can have for Chrome. Revoking tokens we don't need any longer should mitigate the problem. This is identical to https://codereview.chromium.org/13249007/ but with a corrected base url. BUG=224462 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
M chrome/browser/signin/signin_manager.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_manager.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_consumer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 5 chunks +15 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 6 chunks +34 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_urls.h View 2 chunks +2 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_urls.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Michael Courage
Tim or Roger, can one of you rubber stamp this change? It's identical to 13249007, ...
7 years, 8 months ago (2013-04-04 00:11:40 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
7 years, 8 months ago (2013-04-04 12:50:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/13599003/1
7 years, 8 months ago (2013-04-04 17:20:16 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 17:22:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/13599003/1
7 years, 8 months ago (2013-04-04 18:43:20 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 18:45:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/13599003/1
7 years, 8 months ago (2013-04-04 23:02:03 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 04:03:03 UTC) #8
Message was sent while issue was closed.
Change committed as 192491

Powered by Google App Engine
This is Rietveld 408576698