Android: improve native debuggability

Android: improve native debuggability

When starting with --wait-for-debugger command line option, it's ending
up in a busy loop waiting for a variable to be changed. Change that busy
loop from a macro to a function. It avoids having to step on instruction
level to find the right stack frame before the variable is visible.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192944

[Mostyn Bramley-Moore, 2013-04-08 12:18:08]

This is a resubmission of https://codereview.chromium.org/12717018/ using my
new/official account (with nit fixed).

[bulach, 2013-04-08 14:13:58]

lgtm, thanks (but needs darin's OWNERS approval).
tiny nit:

https://codereview.chromium.org/13597005/diff/1/base/debug/debugger_posix.cc
File base/debug/debugger_posix.cc (right):

https://codereview.chromium.org/13597005/diff/1/base/debug/debugger_posix.cc#...
base/debug/debugger_posix.cc:234: }
nit: 
}  // namespace

[Mostyn Bramley-Moore, 2013-04-08 14:17:35]

https://codereview.chromium.org/13597005/diff/1/base/debug/debugger_posix.cc
File base/debug/debugger_posix.cc (right):

https://codereview.chromium.org/13597005/diff/1/base/debug/debugger_posix.cc#...
base/debug/debugger_posix.cc:234: }
On 2013/04/08 14:13:58, bulach wrote:
> nit: 
> }  // namespace

Done.

[darin (slow to review), 2013-04-08 18:56:14]

https://codereview.chromium.org/13597005/diff/4001/base/debug/debugger_posix.cc
File base/debug/debugger_posix.cc (right):

https://codereview.chromium.org/13597005/diff/4001/base/debug/debugger_posix....
base/debug/debugger_posix.cc:221: namespace {
nit: the contents of namespaces should not be indented.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namesp...

https://codereview.chromium.org/13597005/diff/4001/base/debug/debugger_posix....
base/debug/debugger_posix.cc:223: do {
nit: The "do { ... } while (0)" wrapper should no longer be necessary since
DebugBreak() is no longer a preprocessor directive.

[Mostyn Bramley-Moore, 2013-04-08 19:44:07]

https://codereview.chromium.org/13597005/diff/4001/base/debug/debugger_posix.cc
File base/debug/debugger_posix.cc (right):

https://codereview.chromium.org/13597005/diff/4001/base/debug/debugger_posix....
base/debug/debugger_posix.cc:221: namespace {
On 2013/04/08 18:56:14, darin wrote:
> nit: the contents of namespaces should not be indented.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namesp...

Done.

https://codereview.chromium.org/13597005/diff/4001/base/debug/debugger_posix....
base/debug/debugger_posix.cc:223: do {
On 2013/04/08 18:56:14, darin wrote:
> nit: The "do { ... } while (0)" wrapper should no longer be necessary since
> DebugBreak() is no longer a preprocessor directive.

Done.

[darin (slow to review), 2013-04-08 19:52:27]

LGTM

[commit-bot: I haz the power, 2013-04-08 19:52:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/13597005/7001

[commit-bot: I haz the power, 2013-04-08 22:03:01]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-08 22:15:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/13597005/7001

[commit-bot: I haz the power, 2013-04-08 23:26:28]

Change committed as 192944